Bug 603666 - Review Request: python-defconAppKit - A collection of Vanilla objects for use in font editing applications.
Summary: Review Request: python-defconAppKit - A collection of Vanilla objects for use...
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Thomas Spura
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords: i18n
Depends On: 603634 603639
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-14 10:01 UTC by Parag Nemade
Modified: 2011-03-29 06:36 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2011-03-29 06:36:37 UTC


Attachments (Terms of Use)

Description Parag Nemade 2010-06-14 10:01:49 UTC
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-defconAppKit.spec
SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/python-defconAppKit-0.1-1.fc13.src.rpm
Description: 
A collection of Vanilla objects for use in font editing applications.

Comment 1 Thomas Spura 2010-07-22 15:29:48 UTC
Review:

Good:
- name ok
- source match upstream: 95f50ded72ebc5f77a9063b41820929c
- no libs
- buildarch noarch
- no locales
- no *.la
- license ok



Needswork:
- Development/Tools would be better as group
- %files:
  Please be a bit more explicit like in your other packages. (It seems you just forgot it here)
- %{version} should be in url
- Missing R fonttools and python-appkit and python-ufo2fdk

- This one again seems to not install right:
$ rpmls noarch/python-defconAppKit-0.1-1.fc13.noarch.rpm 
drwxr-xr-x  /usr/lib/python2.6/site-packages/defconAppKit
-rw-r--r--  /usr/lib/python2.6/site-packages/defconAppKit-0.1-py2.6.egg-info
-rw-r--r--  /usr/lib/python2.6/site-packages/defconAppKit/__init__.py
-rw-r--r--  /usr/lib/python2.6/site-packages/defconAppKit/__init__.pyc
-rw-r--r--  /usr/lib/python2.6/site-packages/defconAppKit/__init__.pyo
drwxr-xr-x  /usr/share/doc/python-defconAppKit-0.1
-rw-r--r--  /usr/share/doc/python-defconAppKit-0.1/License.txt


Don't know, what's the problem here...
There should be more subfolders in defconAppKit

- Where is Foundation module?
./Lib/defconAppKit/controls/fontInfoView.py:from Foundation import *
Maybe another missing dependency.

Comment 2 Parag Nemade 2011-03-29 06:36:37 UTC
I have no time to work on this. Closing this for now as deferred.


Note You need to log in before you can comment on or make changes to this bug.