Created attachment 424002 [details]
patch for usage of users default keyring
Description of problem:
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.set any keyring as default under gnome which is NOT named "default"
a.e. keyring "loging" is set as default
2.Start virt-manager go to any VM and tick the "save this password to your keyring"
virt-manager will create a keyring which is named "default" and use the users default keyring. a.e. "login"
virt-manager should use the newly created keyring which is named "default", perhaps it should, if this is the wished action, don't create a keyring named "default" instead create a keyring "virt-manager" or similar.
Or it should only use the users default keyring and only create a new one, when no default keyring is available.
I'll allready created a patch which uses suggestion nr. 2.
Thanks, applied a variant of your patch upstream:
I tested the patch and its not working.
Here is the problem:
self.keyring = gnomekeyring.get_default_keyring_sync()
if self.keyring == None:
logging.warning("Failed to create default keyring")
self.keyring == 'default'
If no default keyring is available it creates a new keyring named "default", this is ok so far.
But the new created keyring is never used by the above code and it isn't set as default keyring.
Even if it will be set, after creation as default keyring, by a line like:
It is not opened in the same run.
With the above patch (if I don't have any keyrings) I need to set the created keyring "default" as default keyring manual, instead virt-manager can't use it.
Im very sorry, had a type in applying your patch...
It's all working fine now ;)
Thanks for testing!
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle.
Changing version to '14'.
More information and reason for this action is here:
This is fixed in rawhide now, and queued for F14 with virt-manager 0.8.5
virt-manager-0.8.5-1.fc13 has been submitted as an update for Fedora 13.
virt-manager-0.8.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.