Bug 605413 - Review Request: pymongo - Python driver for MongoDB
Review Request: pymongo - Python driver for MongoDB
Status: CLOSED DUPLICATE of bug 644708
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-17 17:09 EDT by Ian Weller
Modified: 2010-10-19 22:14 EDT (History)
7 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-10-11 03:55:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
pymongo spec with el5 fixes (2.68 KB, application/octet-stream)
2010-10-11 00:52 EDT, Nathaniel McCallum
no flags Details

  None (edit)
Description Ian Weller 2010-06-17 17:09:18 EDT
Spec URL: http://ianweller.fedorapeople.org/SRPMS/pymongo/1.6-1/pymongo.spec
SRPM URL: http://ianweller.fedorapeople.org/SRPMS/pymongo/1.6-1/pymongo-1.6-1.fc13.src.rpm
Description: 
The PyMongo distribution contains tools for interacting with MongoDB database
from Python. The pymongo package is a native Python driver for MongoDB. The
gridfs package is a gridfs implementation on top of pymongo.
Comment 1 Thomas Spura 2010-06-19 11:57:14 EDT
Just a few comments for now:

- There is a new version, released just seconds, after your review request ;)

- There is an anoying private-shared-object-provides warning from rpmlint. This can be easily grepped out of the provides list, but that's only a workaround.

  I just mailed the python list about this and hopefully this will be fixed in the find-requires script and not workaround this in any python package, that's not noarch...
  http://lists.fedoraproject.org/pipermail/python-devel/2010-June/000260.html

- Didn't have a close look yet, but on upstreams page is a testsuite mentioned, could you please add a %check section?
Comment 2 Ian Weller 2010-06-19 15:01:38 EDT
(In reply to comment #1)
> - There is a new version, released just seconds, after your review request ;)

Well, that's irritating. ;)

> - Didn't have a close look yet, but on upstreams page is a testsuite mentioned,
> could you please add a %check section?    

The test suite requires a running mongoDB server so I don't think that's something we want to hack together in %check.

New spec in a bit, just wanted to respond to that last thing before I forgot.
Comment 3 Marian Csontos 2010-09-03 06:49:58 EDT
Though I do not like uppercase, may be using PyMongo as name would be more appropriate: the project refers to itself PyMongo everywhere.

This distinguishes between PyMongo project and pymongo python package.

IIUC PyMongo == pymongo + gridfs
Comment 4 Matthias Runge 2010-09-06 05:45:38 EDT
As Marian suggested, you should probably divide gridfs and pymongo or make at least subpackages. e.g. PyMongo-gridfs and PyMongo-pymongo.
Comment 5 Matthias Runge 2010-09-23 03:26:15 EDT
Ping Ian. 

Any progress? mongodb is now a package included in fedora etc. 

https://admin.fedoraproject.org/pkgdb/acls/name/mongodb/

How can I support you?
Comment 6 Silas Sewell 2010-09-28 11:10:07 EDT
Here is my personal spec that addresses some things mentioned above (as you can see I prefer lowercase names, something Debian gets right).

http://github.com/silas/rpms/raw/master/pymongo/pymongo.spec

Ian Weller if you update your spec I'd be happy to review it, otherwise I'd also be happy to take the request over if you're not interested anymore.
Comment 7 Nathaniel McCallum 2010-10-10 23:50:19 EDT
Silas, if you want to run with it, I'll do the review.  Or vice-versa.  I just want it packaged. ;)
Comment 8 Ian Weller 2010-10-10 23:51:46 EDT
Either of you can go ahead and take it, I've got no time. Sorry for the delays guys :(
Comment 9 Nathaniel McCallum 2010-10-11 00:52:54 EDT
Created attachment 452639 [details]
pymongo spec with el5 fixes
Comment 10 Matthias Runge 2010-10-11 03:23:48 EDT
Oh great, guys. If you need any help, I'd jump in.
Comment 11 Thomas Spura 2010-10-11 03:55:04 EDT
(In reply to comment #8)
> Either of you can go ahead and take it, I've got no time. Sorry for the delays
> guys :(

-> Closing as NOTABUG

Anyone, who wants to continue the review of pymongo needs to open a own review request and close this one as a dub of the new one, see:
http://fedoraproject.org/wiki/Extras/Policy/StalledReviews#Submitter_not_responding
Comment 12 Silas Sewell 2010-10-19 22:14:59 EDT

*** This bug has been marked as a duplicate of bug 644708 ***

Note You need to log in before you can comment on or make changes to this bug.