Red Hat Bugzilla – Bug 605413
Review Request: pymongo - Python driver for MongoDB
Last modified: 2010-10-19 22:14:59 EDT
Spec URL: http://ianweller.fedorapeople.org/SRPMS/pymongo/1.6-1/pymongo.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/pymongo/1.6-1/pymongo-1.6-1.fc13.src.rpm Description: The PyMongo distribution contains tools for interacting with MongoDB database from Python. The pymongo package is a native Python driver for MongoDB. The gridfs package is a gridfs implementation on top of pymongo.
Just a few comments for now: - There is a new version, released just seconds, after your review request ;) - There is an anoying private-shared-object-provides warning from rpmlint. This can be easily grepped out of the provides list, but that's only a workaround. I just mailed the python list about this and hopefully this will be fixed in the find-requires script and not workaround this in any python package, that's not noarch... http://lists.fedoraproject.org/pipermail/python-devel/2010-June/000260.html - Didn't have a close look yet, but on upstreams page is a testsuite mentioned, could you please add a %check section?
(In reply to comment #1) > - There is a new version, released just seconds, after your review request ;) Well, that's irritating. ;) > - Didn't have a close look yet, but on upstreams page is a testsuite mentioned, > could you please add a %check section? The test suite requires a running mongoDB server so I don't think that's something we want to hack together in %check. New spec in a bit, just wanted to respond to that last thing before I forgot.
Though I do not like uppercase, may be using PyMongo as name would be more appropriate: the project refers to itself PyMongo everywhere. This distinguishes between PyMongo project and pymongo python package. IIUC PyMongo == pymongo + gridfs
As Marian suggested, you should probably divide gridfs and pymongo or make at least subpackages. e.g. PyMongo-gridfs and PyMongo-pymongo.
Ping Ian. Any progress? mongodb is now a package included in fedora etc. https://admin.fedoraproject.org/pkgdb/acls/name/mongodb/ How can I support you?
Here is my personal spec that addresses some things mentioned above (as you can see I prefer lowercase names, something Debian gets right). http://github.com/silas/rpms/raw/master/pymongo/pymongo.spec Ian Weller if you update your spec I'd be happy to review it, otherwise I'd also be happy to take the request over if you're not interested anymore.
Silas, if you want to run with it, I'll do the review. Or vice-versa. I just want it packaged. ;)
Either of you can go ahead and take it, I've got no time. Sorry for the delays guys :(
Created attachment 452639 [details] pymongo spec with el5 fixes
Oh great, guys. If you need any help, I'd jump in.
(In reply to comment #8) > Either of you can go ahead and take it, I've got no time. Sorry for the delays > guys :( -> Closing as NOTABUG Anyone, who wants to continue the review of pymongo needs to open a own review request and close this one as a dub of the new one, see: http://fedoraproject.org/wiki/Extras/Policy/StalledReviews#Submitter_not_responding
*** This bug has been marked as a duplicate of bug 644708 ***