Bug 605734
| Summary: | initscript actions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Karel Volný <kvolny> | ||||
| Component: | edac-utils | Assignee: | Mauro Carvalho Chehab <mchehab> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Alex Sersen <asersen> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 6.0 | CC: | asersen, azelinka, dkovalsk, lwang, ohudlick, omoris, syeghiay, ykopkova | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | edac-utils-0.9-11.2.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 632665 (view as bug list) | Environment: | |||||
| Last Closed: | 2010-11-10 20:20:55 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 579073, 632665, 633349 | ||||||
| Attachments: |
|
||||||
|
Description
Karel Volný
2010-06-18 16:15:50 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. (In reply to comment #0) > 4) running "service edac status" after "service edac stop" returns 0 instead of > 3 > > 5) running "service edac reload" on a stopped service returns 0 instead of 7 > and restarts the service Such return codes wouldn't make any sense on this case. This script should not be different than the one provided for bluetooth, where only a start method is defined: start() { echo -n $"Enabling Bluetooth devices:" udevadm trigger --subsystem-match=bluetooth echo "" return 0 } stop() { # FIXME If somebody figures out how to disable the K* script echo -n "Stopping Bluetooth services:" echo "" return 0 } It is just the same case: we just need to run edac-ctl during start method, in order to load some parameters at the corresponding kernel driver. This script doesn't start any deamon that needs to be stopped. I think I'll rewrite the init script to look more like the above, adding some fake methods for all those restart methods that will just call edac-ctl whatever argument provided, except for stop and usage. Created attachment 426119 [details] New EDAC SysV script New script that fulfills all requirements stated at: https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_the_filesystem Since this script just sends some data to EDAC kernel driver, there's no stop action, nor there is a "daemon status". So, all actions that asks for reload will just do the same action as "start": send the new memory labels table to the Kernel driver. "stop" and "status" will just return 0, as there's no way (nor make sense) to stop a non-daemon process. New SysV script added at: edac-utils-0.9-11.2.el6.src.rpm Red Hat Enterprise Linux 6.0 is now available and should resolve the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you. |