Spec URL: http://nathaniel.themccallums.org/rpms/python-snpp.spec SRPM URL: http://nathaniel.themccallums.org/rpms/python-snpp-1.1.2-1.fc13.src.rpm Description: Libraries implementing RFC 1861 - Simple Network Paging Protocol
Review: Good: - name ok - %build ok - %install ok - macros everywhere - no libs/*.la - license ok (according to the headers, so COPYING file, see needswork) - noarch ok - rpmlint ok $ rpmlint ./python-snpp-1.1.2-1.fc13.src.rpm noarch/python-snpp-1.1.2-1.fc13.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - sources match upstream: bab9732f7ddf3af54fb5262b6dae35da Needswork: - missing BR python-setuptools - query upstream to include a proper COPYING file with the license - summary unnecessary to long: "Simple Network Paging Protocol" would be enought, the rest is in description anyway - group wrong: You say this are 'libraries' -> Development/Libraries? - It would be better, if you could write in %files: %{python_sitelib}/Pager.py* %{python_sitelib}/snpplib.py* %{python_sitelib}/python_snpp*.egg-info So you know, when building the egg fails (e.g. I still wonder, why there is a already an egg-info in the archive...)
(In reply to comment #1) > So you know, when building the egg fails (e.g. I still wonder, why there is a > already an egg-info in the archive...) FYI, those prebuild egg-info can be deleted in %prep, setuptools will regenerate it in %install.
(In reply to comment #2) > (In reply to comment #1) > > So you know, when building the egg fails (e.g. I still wonder, why there is a > > already an egg-info in the archive...) > > FYI, those prebuild egg-info can be deleted in %prep, setuptools will > regenerate it in %install. Yup, if I were upstream I wouldn't include it... I still don't see the reason for including it... Using a more verbose %files section for verifying the egg building is very common in fedora anyway, so this does not depend on deleting this egg-info and rebuilding with setuptools.
I've fixed all the issues mentioned above. http://nathaniel.themccallums.org/rpms/python-snpp.spec http://nathaniel.themccallums.org/rpms/python-snpp-1.1.2-2.fc13.src.rpm
Last thing to do: koji build sucessfull: http://koji.fedoraproject.org/koji/taskinfo?taskID=2259281 ################################################################################ APPROVED
New Package CVS Request ======================= Package Name: python-snpp Short Description: Simple Network Paging Protocol Owners: npmccallum Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).