Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 606189

Summary: Review Request: ipa-gothic-fonts - Japanese Gothic-typeface OpenType font by IPA
Product: Red Hat Enterprise Linux 5 Reporter: Akira TAGOH <tagoh>
Component: Package ReviewAssignee: Jens Petersen <petersen>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: 5.6CC: bzeranski, eng-i18n-bugs, ltroan, notting, pm-rhel
Target Milestone: betaKeywords: FutureFeature, OtherQA
Target Release: 5.6   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-16 08:28:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 496824    
Bug Blocks: 188273, 537251, 539334, 547220, 557597, 606192, 606201    

Description Akira TAGOH 2010-06-21 04:59:30 UTC
Spec URL: http://cvs.fedoraproject.org/viewvc/rpms/ipa-gothic-fonts/devel/ipa-gothic-fonts.spec?revision=1.8&view=markup
SRPM URL: http://kojipkgs.fedoraproject.org/packages/ipa-gothic-fonts/003.02/5.fc14/src/ipa-gothic-fonts-003.02-5.fc14.src.rpm
Description:
IPA Font is a Japanese OpenType fonts that is JIS X 0213:2004
compliant, provided by Information-technology Promotion Agency, Japan.

This package contains Gothic (sans-serif) style font.

Comment 4 Akira TAGOH 2010-07-23 08:00:21 UTC
Update the URL to keep consistency of NVR between the product version:

Spec URL: http://people.redhat.com/tagoh/ipa-gothic-fonts/ipa-gothic-fonts.spec
SRPM URL: http://people.redhat.com/tagoh/ipa-gothic-fonts/ipa-gothic-fonts-003.02-4.2.el6.src.rpm

Comment 5 Larry Troan 2010-07-28 00:39:21 UTC
Raising to HIGH. Required for Japanese markets so characters display properly and compliant with Windows. This is a new component. Set EXCEPTION=?.

Comment 6 Jens Petersen 2010-07-28 09:39:24 UTC
(In reply to comment #4)
> Spec URL: http://people.redhat.com/tagoh/ipa-gothic-fonts/ipa-gothic-fonts.spec
> SRPM URL:
> http://people.redhat.com/tagoh/ipa-gothic-fonts/ipa-gothic-fonts-003.02-4.2.el6.src.rpm    

Thanks

The package is identical to the current package in RHEL6
and also current Fedora packages, so not too much to consider.

I tried to install however and it fails because there is
no fontpackages-filesystem in RHEL5.  fontconfig
provides /etc/fonts/conf.d and /usr/share/fonts.

I guess the conf.avail file needs to move back to
/etc/fonts/conf.avail too.

Comment 8 Larry Troan 2010-07-29 11:42:10 UTC
Jens,
You worked to get the other ipa-* fonts included in RHEL5. Can you please take this one as well.

Comment 9 Akira TAGOH 2010-07-29 12:50:39 UTC
(In reply to comment #6)
> The package is identical to the current package in RHEL6
> and also current Fedora packages, so not too much to consider.
> 
> I tried to install however and it fails because there is
> no fontpackages-filesystem in RHEL5.  fontconfig
> provides /etc/fonts/conf.d and /usr/share/fonts.
> 
> I guess the conf.avail file needs to move back to
> /etc/fonts/conf.avail too.    

Thank you for catching that up. that also means the package also needs to be modified to get rid of fontpackages-devel deps too because the spec file is simplified with the macro provided by that package. this change brings up whether ipa-*-fonts packages owns the above config dir or add a Requires: fontconfig. though we could leave it as is too.

Aside from that, we didn't have any fontconfig config files for fonts packages in RHEL-5 basically, it behaves differently a bit comparing to RHEL-6. for example, just installing packages may make it default immediately because no fontconfig files is available prior to read IPA's.

Comment 10 Jens Petersen 2010-07-30 05:58:22 UTC
I agree with your conclusions let's just drop the .conf files for RHEL5 for now.

Comment 11 Jens Petersen 2010-07-30 06:02:13 UTC
or just include avail.d perhaps if customers want to customize. :)

Comment 14 Jens Petersen 2010-08-05 08:28:39 UTC
Summary review:

- Package is following standard fonts packaging
- Minor changes to RHEL6 package for backport to RHEL5
- Package has been in Fedora since April 2009 (F12)
- Package builds on RHEL5
http://brewweb.devel.redhat.com/brew/taskinfo?taskID=2656651
- Tested on RHEL 5.6 together with other IPA packages
- Verified source md5sum:
cc9f6472b1b6f2aa7fb06dcc085f6923  ipag00302.zip

Package reviewed and APPROVED for inclusion in RHEL5.


However I think we should keep el5 < el6.
How about resetting the release field to 1 or at least using 4.2.el5.1
when importing the package?

Comment 15 Akira TAGOH 2010-08-05 09:11:11 UTC
Sure. I prefer keeping the inheritance in the NVR so will move the release number for the changes in rhel5 after dist tag then.

Comment 16 Akira TAGOH 2010-08-16 08:28:07 UTC
thanks, the package has been imported and built after changing the release to 4.2.el5.1.