Bug 606387 - incorrect aggregate metric value computations for resourceGroups / autoGroups
Summary: incorrect aggregate metric value computations for resourceGroups / autoGroups
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core UI
Version: 3.0.0
Hardware: All
OS: Linux
low
medium vote
Target Milestone: ---
: ---
Assignee: Joseph Marques
QA Contact: Corey Welton
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-21 14:14 UTC by Joseph Marques
Modified: 2010-08-12 16:51 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2010-08-12 16:51:57 UTC


Attachments (Terms of Use)

Description Joseph Marques 2010-06-21 14:14:18 UTC
Description of problem:

incorrect value for "Group Members Reporting" column in monitor>tables sub-tab

Steps to Reproduce:
1. Navigate to either an autogroup or resource group
2. Go to monitor>tables sub-tab

Expected results:

The "Group Members Reporting" should be a number greater than or equal to 0, but less than or equal to the size of the autogroup/resourcegroup.  It should be a number that represents the number of resources that have the measurement schedule (for each individual row) enabled.
  
Actual results:

The number is much larger than the size of the group.

Comment 1 Joseph Marques 2010-06-21 14:16:06 UTC
commit 05e4759fd8a557a2cdfacf82986e3f7017e46e8a
Author: Joseph Marques <joseph@redhat.com>
Date:   Mon Jun 21 10:12:42 2010 -0400

    BZ-606387: fix "Group Members Reporting" column for monitor>tables sub-tab

-----

turns out the count-query wasn't filtering by the measurement schedule in question, and so it was counting every single measurement schedule in the system for every row of the monitor>tables view.

Comment 2 Joseph Marques 2010-06-21 14:44:00 UTC
A second issue is that all of the metric display summaries are the same.  It doesn't matter how many different metrics there are for a resource, their min/max/avg values will all be the same.  This is caused by the same type of bug that triggered the "Group Members Reporting" count to be wrong.

Comment 3 Joseph Marques 2010-06-21 14:50:15 UTC
commit 951dfe9d075a5dc3d200aaeff14e46a7d53d30d5
Author: Joseph Marques <joseph@redhat.com>
Date:   Mon Jun 21 10:44:28 2010 -0400

    BZ-606387: fix metric display summary values for autoGroups/resourceGroups

-----

same issue here - the metrics weren't being properly filtered by the corresponding measurement definition/schedule, and so every metric being displayed by a sum of *all* metrics for *all* resource members under each autoGroup / resourceGroup.

Comment 4 Corey Welton 2010-06-23 12:41:32 UTC
QA Verified, these numbers are now correct.

Comment 5 Corey Welton 2010-08-12 16:51:57 UTC
Mass-closure of verified bugs against JON.


Note You need to log in before you can comment on or make changes to this bug.