Red Hat Bugzilla – Bug 606421
Review Request: quickfix - Open Source FIX Engine
Last modified: 2014-01-16 04:21:01 EST
Spec URL: http://www.martindengler.com/proj/quickfix/build-20100620/quickfix.spec
SRPM URL: http://www.martindengler.com/proj/quickfix/build-20100620/quickfix-1.13.3-1.fc12.src.rpm
I've updated the packaged software's version to the latest released version and added two subpackages: python and examples.
rpmlint is cleaner than when I found it:
quickfix-examples.x86_64: W: no-documentation
quickfix-examples.x86_64: W: no-manual-page-for-binary quickfix-tradeclient
quickfix-examples.x86_64: W: no-manual-page-for-binary quickfix-ordermatch
quickfix-examples.x86_64: W: no-manual-page-for-binary quickfix-executor
...none of which fit into any MUST requirements from http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Things_To_Check_On_Review .
I'm not sure what else to request / draw attention to; I guess I'll add FE-NEEDSPONSOR and wait for a review per http://fedoraproject.org/wiki/Package_Review_Process .
PS - this package is orphaned and I intend to start doing informal reviews per the howto-get-sponsored guide.
I'll also try to contact Hayden James, who seems to be the original maintainer in case he's just lurking, per the non-responsive maintainer process.
I've contacted Hayden Jones via his gmail account and he's happy for me to take over maintenance of this package.
Corrected bug summary.
First of all, would you examine why build fails on F-12 ppc/ppc64?
The "previous" version of quickfix builds even on F-12 ppc/ppc64:
Also you should package UnitTest++ seperately and make quickfix be
linked against system-wide UnitTest++:
(In reply to comment #4)
> First of all, would you examine why build fails on F-12 ppc/ppc64?
I tried it too - sorry I didn't mention that to save you the time to build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2262986
I've asked http://sourceforge.net/mailarchive/message.php?msg_name=20100621162923.GF16854@ops-13.xades.com - so far no response, unfort. I'll file a bug upstream and follow the ExcludeArch policy if I can't figure it out myself.
> The "previous" version of quickfix builds even on F-12 ppc/ppc64:
I don't think it's going to be too simple - there are four years or so between the new & old code.
(In reply to comment #5)
> Also you should package UnitTest++ seperately and make quickfix be
> linked against system-wide UnitTest++:
Thanks - will do.
And thanks for looking at this review request in the first place.
(In reply to comment #7)
> (In reply to comment #5)
> > Also you should package UnitTest++ seperately and make quickfix be
> > linked against system-wide UnitTest++:
> > http://sourceforge.net/projects/unittest-cpp/
> Thanks - will do.
Thank you. After you file a review request for UnitTest++, please
write the bug number on this bug.
Sorry for the delay (I have been busy IRL). I will pick this up soon, I hope (FLW, I know).
Sorry, again ping?
I will close this bug as NOTABUG if no response is received within
Sorry for the delay...I'm using the already-packaged unittest now but I'm having to teach the build system more about autotools / automake than it and I know. It's getting there.
At least would you submit a review request for unittest-cpp?
(In reply to comment #16)
> At least would you submit a review request for unittest-cpp?
It's already packaged, so that saves us some time: http://koji.fedoraproject.org/koji/buildinfo?buildID=140249
Thanks for sticking with this. I am still working on it, but it's really tedious to make it autotools-friendly and I don't have much time now, sorry. Thank you for keeping this alive.
Marking as not being ready; please clear the whiteboard when you believe this is ready to be reviewed.
I've updated and improved the package for F14, which builds fine ( http://koji.fedoraproject.org/koji/taskinfo?taskID=3008700 )...excising the upstream-distributed UnitTest++ version is all that remains before another review.
I've updated the package for F15, which builds fine ( http://koji.fedoraproject.org/koji/taskinfo?taskID=3098671 )...I've uploaded the SRPM and patches to http://www.martindengler.com/proj/quickfix/build-20110529 and http://www.martindengler.com/proj/quickfix/patches-20110529 , respectively, in case anyone wants to try it out.
I've updated the package for F16, which builds fine ( http://koji.fedoraproject.org/koji/taskinfo?taskID=3846127 ) ...I've uploaded the SRPM and patches to http://www.martindengler.com/proj/quickfix/build-20120210 and http://www.martindengler.com/proj/quickfix/build-20120210 , respectively, in case anyone wants to try it out.
I am going to rip out the included unittest code this weekend and hopefully that will finish this off. I will clear the whiteboard. If there is anything else people know they would like me to see for the review then please let me know.
The UnitTest++ subdirs have the example cfg and data files in them, so I need to reshuffle them. And then figure out with upstream what to do about that long-term. Still working on this.
Again once closing this old ticket.
If someone is interesting in importing this package into Fedora, please submit a new review request, thank you.