Bug 607081 (perl-Data-Taxi) - Review Request: perl-Data-Taxi - Taint-aware, XML-ish data serialization
Summary: Review Request: perl-Data-Taxi - Taint-aware, XML-ish data serialization
Keywords:
Status: CLOSED ERRATA
Alias: perl-Data-Taxi
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Data-Taxi/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-23 07:31 UTC by Iain Arnell
Modified: 2010-07-08 18:27 UTC (History)
4 users (show)

Fixed In Version: perl-Data-Taxi-0.95-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-07-08 18:15:42 UTC
panemade: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2010-06-23 07:31:53 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Data-Taxi.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Data-Taxi-0.95-1.fc14.src.rpm

Description:
Taxi (Taint-Aware XML-Ish) is a data serializer with several handy
features.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2266895

*rt-0.10_01

Comment 1 Parag AN(पराग) 2010-06-23 10:34:28 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2266895
+ rpmlint output for SRPM and for RPM.
perl-Data-Taxi.noarch: W: spelling-error Summary(en_US) ish -> is, sh, dish
perl-Data-Taxi.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
perl-Data-Taxi.src: W: spelling-error Summary(en_US) ish -> is, sh, dish
perl-Data-Taxi.src: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ source files match upstream url (sha1sum)
e7bed3a84a844d669219fd77d74ba44cbb562943  Data-Taxi-0.95.tar.gz
e7bed3a84a844d669219fd77d74ba44cbb562943  Data-Taxi-0.95.tar.gz.srpm

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
ok 1
+ Package perl-Data-Taxi-0.95-1.fc14.noarch=>
Provides: perl(Data::Taxi) = 0.95
Requires: perl >= 0:5.006 perl(Carp) perl(constant) perl(Exporter) perl(strict) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1
+ Not a GUI application

Suggestions:
1) I think Changelog should include email id of packager also.

APPROVED.

Comment 2 Ralf Corsepius 2010-06-23 11:20:28 UTC
@Ian: why do you need this package?

This package appears dead and unsupported, to me:

From http://search.cpan.org/~miko/Data-Taxi-0.95/Taxi.pm
"PLEASE NOTE: Data::Taxi is no longer being developed or supported."

Provided this, unless there is a very strong reason to include it into Fedora, my advise would be not to include it and to revoke the approval, because in longer terms such packages tend to become broken and unmaintainable.

Comment 3 Iain Arnell 2010-06-23 15:50:54 UTC
(In reply to comment #2)

It's an optional dependency of Catalyst-Action-REST. There are currently no active bugs upstream, nor any notable test failures. If it does prove troublesome in future, I'd be happy becoming upstream (or dropping it if it becomes too badly broken).

Comment 4 Iain Arnell 2010-06-25 03:06:02 UTC
New Package CVS Request
=======================
Package Name: perl-Data-Taxi
Short Description: Taint-aware, XML-ish data serialization
Owners: iarnell
Branches: F-12 F-13
InitialCC: perl-sig

Comment 5 Jason Tibbitts 2010-06-26 08:05:20 UTC
CVS done (by process-cvs-requests.py).

Comment 6 Iain Arnell 2010-06-26 11:00:13 UTC
spec fixed and imported to rawhide

Comment 7 Fedora Update System 2010-06-26 11:01:12 UTC
perl-Data-Taxi-0.95-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-Data-Taxi-0.95-1.fc13

Comment 8 Fedora Update System 2010-06-26 11:01:20 UTC
perl-Data-Taxi-0.95-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-Data-Taxi-0.95-1.fc12

Comment 9 Fedora Update System 2010-06-28 17:10:57 UTC
perl-Data-Taxi-0.95-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Data-Taxi'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Data-Taxi-0.95-1.fc12

Comment 10 Fedora Update System 2010-06-28 17:19:37 UTC
perl-Data-Taxi-0.95-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Data-Taxi'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Data-Taxi-0.95-1.fc13

Comment 11 Fedora Update System 2010-07-08 18:15:34 UTC
perl-Data-Taxi-0.95-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2010-07-08 18:27:45 UTC
perl-Data-Taxi-0.95-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.