Spec URL: http://www.kylev.com/tmp/python-markupsafe.spec SRPM URL: http://www.kylev.com/tmp/python-markupsafe-0.9.2-1.fc13.src.rpm Description: This is actually a new dependency for python-mako as of version 0.3.4 (which is a security fix release).
A couple of quick comments; I'll do a full review once the package builds. The spec looks as clean as can be for something that supports python 2 and 3 as well as F12 and EPEL. However, some additional conditionals are needed for the first two lines as python3 isn't available on F12 or EPEL and F13 doesn't need the python_site* define. (F13 also doesn't need %clean, the BuildRoot line or the buildroot cleaning in %install, but it's pointless to conditionalize those.) So: %if 0%{?fedora} > 12 || 0%{?rhel} > 6 %global with_python3 1 %else %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())")} %endif (probably horribly wordwrapped) and things are good. Also, I suspect this will have problems on F12 anyway as its arch-specific so you probably want the python_sitearch define there instead of sitelib, especially since sitearch is used in %files. Unfortunately this fails to build for me in rawhide; setyp.py won't run because setuptools is not installed. A scratch build is at http://koji.fedoraproject.org/koji/taskinfo?taskID=2269296
Updated with fixed with_python3 and sitearch rather than sitelib. Spec in same place, new SRPM http://www.kylev.com/tmp/python-markupsafe-0.9.2-2.fc13.src.rpm
Still fails to build on rawhide, same error as before.
It does build OK if I add a build dependency on python-setuptools-devel and a conditionalized dep on python3-setuptools.
I totally blew it and missed your second paragraph. Fixed BuildRequires and have done scratch builds for rawhide, F-13, F-12 and EPEL-5 (all the targets that Mako is currently on). http://www.kylev.com/tmp/python-markupsafe-0.9.2-3.fc13.src.rpm
Yep, that builds fine for me. rpmlint just says: python-markupsafe.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/markupsafe/_speedups.so _speedups.so() (64bit) which as far as I know you can't do anything about because we have no dependency filtering for arch-specific packages. The only issue I see: perhaps I'm missing something, but does the URL actually have anything at all to do with this package? I can't find any mention at all of this module at http://dev.pocoo.org/. It's what pypi says, so I'm no going to fret over it, but it seems a bit odd. Honestly I'd probably list the pypi page here instead because it at least has useful information related to the module. * source files match upstream. sha256sum: d2a1980ea5bae80a999dad6aafe1ad2f0440522630caeecb84ffe061c8054342 MarkupSafe-0.9.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: python3-markupsafe-0.9.2-3.fc14.x86_64.rpm _speedups.so()(64bit) python3-markupsafe = 0.9.2-3.fc14 python3-markupsafe(x86-64) = 0.9.2-3.fc14 = libpython3.1.so.1.0()(64bit) python(abi) = 3.1 python-markupsafe-0.9.2-3.fc14.x86_64.rpm _speedups.so()(64bit) python-markupsafe = 0.9.2-3.fc14 python-markupsafe(x86-64) = 0.9.2-3.fc14 = libpython2.6.so.1.0()(64bit) python(abi) = 2.6 * %check is present and all tests pass: Ran 2 tests in 0.270s Ran 2 tests in 0.253s * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED
New Package CVS Request ======================= Package Name: python-markupsafe Short Description: XML/HTML/XHTML Markup safe string for Python Owners: kylev lmacken Branches: F-12 F-13 EL-5 InitialCC:
CVS done (by process-cvs-requests.py).
python-markupsafe-0.9.2-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-markupsafe-0.9.2-3.fc13
python-markupsafe-0.9.2-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-markupsafe-0.9.2-3.fc12
python-markupsafe-0.9.2-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-markupsafe-0.9.2-3.el5
python-markupsafe-0.9.2-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
python-markupsafe-0.9.2-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
python-markupsafe-0.9.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.