Bug 607877 - Review Request: perl-XML-FeedPP - Parse/write/merge/edit RSS/RDF/Atom syndication feeds
Summary: Review Request: perl-XML-FeedPP - Parse/write/merge/edit RSS/RDF/Atom syndica...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mark Chappell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 607878
Blocks: 607873
TreeView+ depends on / blocked
 
Reported: 2010-06-25 04:27 UTC by Jeroen van Meeuwen
Modified: 2014-01-13 10:01 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-13 10:01:16 UTC
Type: ---
Embargoed:
tremble: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Mark Chappell 2010-06-25 14:40:39 UTC
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
  [x] Versioned MODULE_COMPAT_ Requires
  [x] Non-Versioned CPAN URL tag
 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: local mock (i386)
 [x] Rpmlint output:

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
     Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license. 
     License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided in the spec URL.
     Upstream: dd08f2bdb0850ae9470c5ae0a948d21d
     SRPM: dd08f2bdb0850ae9470c5ae0a948d21d
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: epel-5-i386 (local mock due to deps)
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: epel-5-i386 (local mock due to deps)
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=43, Tests=1367,  3 wallclock secs ( 2.09 cusr +  0.30 csys =  2.39 CPU)

=== COMMENTS ===

Package looks good, again provisionally APPROVED, will set flag once perl-XML-TreePP is approved

Comment 2 Mark Chappell 2010-06-27 11:37:55 UTC
Note: 0.42 appears to be available.

Comment 3 Jeroen van Meeuwen 2010-06-27 11:59:47 UTC
I cannot find 0.42 on cpan.org, where did you find 0.42?

Comment 4 Mark Chappell 2010-06-27 12:29:22 UTC
Ah, sorry that was XML-Feed not XML-FeedPP

Comment 5 Jeroen van Meeuwen 2010-06-28 09:23:23 UTC
New Package CVS Request
=======================
Package Name: perl-XML-FeedPP
Short Description: Parse/write/merge/edit RSS/RDF/Atom syndication feeds
Owners: kanarip
Branches: EL-4 EL-5 EL-6 F-12 F-13 devel
InitialCC:

Comment 6 Jason Tibbitts 2010-06-28 16:44:11 UTC
CVS done (by process-cvs-requests.py).

Comment 7 Mark Chappell 2014-01-13 10:01:16 UTC
Reviewed, CVS added and built, closing off old review.


Note You need to log in before you can comment on or make changes to this bug.