Red Hat Bugzilla – Bug 608937
Should beaker Require: python-setuptools, python-paste, and pycryptopp?
Last modified: 2011-09-08 03:46:34 EDT
Created attachment 427534 [details]
Patch to use paste.util.converters instead of bundled copy
Description of problem:
It appears that beaker imports three python libraries that aren't listed in Requires:
pycryptopp is used in beaker/crypto/pycryptopp.py (python-crypto is listed as the second choice and could be used on EPEL-5 where pycryptopp isn't yet available.
python-paste is used in beaker/middleware.py
pkg_resources (from python-setuptools) is used in beaker/cache.py
Version-Release number of selected component (if applicable):
Should be able to add something like this:
I looked into this because beaker has a verbatim copy of a file from paste:
beaker/converters.py is a copy of paste/util/converters.py
If paste is already a requirement we should submit something to upstream to use the paste version instead of a bundled copy. I'll attach a patch that does that.
Adding those additional dependencies and patch is fine with me. It is probably something we want to send upstream as well.
Briefly talked to Ben and he thinks being able to work without setuptools and paste installed is an advantage. The imports are inside try: except blocks so even if the code loses some functionality, it can still work.
So I'll add pycryptopp but not the others.
Makes me wonder what to do about the one copied file.. I could either put it in a try: except or not worry about it.
Created attachment 427538 [details]
use try: except to use paste.util.converters if available
Here's what the patch would look like if we try paste.util.converters first and fallback to the bundled copy. Not sure if it makes sense to apply or not.
I've opened a bug with the patch upstream:
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle.
Changing version to '14'.
More information and reason for this action is here:
This is done upstream wouldn't take everything but our version is not bundling and is requiring the necessary packages.