Bug 608966
| Summary: | uncommitted text color is not properly set in kwrite | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Kenichi Takemura <ktakemur> | ||||
| Component: | ibus-qt | Assignee: | fujiwara <tfujiwar> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | QE Internationalization Bugs <qe-i18n-bugs> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 6.0 | CC: | ebaak, eng-i18n-bugs, llim, psatpute, syeghiay | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ibus-qt-1.3.0-2.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 616277 (view as bug list) | Environment: | |||||
| Last Closed: | 2010-07-29 06:54:29 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 616277 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Kenichi Takemura
2010-06-29 04:03:52 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. I can reproduce it even on Fedora 13, if ibus-qt is installed (screenshot attached). ibus-hangul uses white/black (fg/bg) for preedit text and requests these settings to applications via ibus-qt. However, the KTextEdit control (which kwrite uses) overrides the bg setting. The solution would be to make KTextEdit (kdelibs) not overwrite existing text attributes, but it might not be easy. Another solution is to choose reasonable default colors for ibus-hangul preedit as in other IME. Created attachment 427599 [details]
screenshot when I type "rlagrlagrla" with ibus-hangul on kwrite
same problem is occurring in ibus-rawcode as well see https://bugzilla.redhat.com/show_bug.cgi?id=613520 i think we should fix this from ibus-qt side, so will no need to change all ime-engine's code I could reproduce this problem. I almost understood the root cause. Will update the evaluation later. I just saw on fedora 13 with kdebase 4.4.5-1, this problem is not coming. Tested for ibus-rawcode (In reply to comment #9) > I just saw on fedora 13 with kdebase 4.4.5-1, this problem is not coming. > Tested for ibus-rawcode I can reproduce the same bug in f13 kdebase 4.4.5-1 and f14. ibus-hangul's engine sets foreground is white and background is black. The problem is, the foreground color only is set in the actual preedit GUI but the background color is lost and this causes both the foreground and the background color are white and users cannot read the preedit text. kdelibs-4.3.4/kate/render/katerenderer.cpp: QList<QTextLayout::FormatRange> KateRenderer::decorationsForLine( const KateTextLine::Ptr& textLine, int line, bool selectionsOnly, KateRenderRange* completionHighlight, bool completionSelected ) const { fr.format = *a; } It seems kde kate rendering get one format only. But ibus-qt sends multiple formats with QAttribute. The solution is ibus-qt has one format only and it can have both foreground and background colors. The suggested patch: http://github.com/fujiwarat/ibus-qt/commit/5fa9738dc4147f11abc420efc217c4c6e7029b77 Integrated the same fix in fedora rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2345562 i have tested F13 Build http://koji.fedoraproject.org/koji/taskinfo?taskID=2346026 on RHEL6 It is resolving problem of ibus-rawcode on RHEL6 thanks fujuwara *** Bug 613520 has been marked as a duplicate of this bug. *** Integrated the fix. Verified in kwrite with all supported input method tree:RHEL6.0-20100728.1 ibus-qt-1.3.0-2.el6 |