Spec URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Controller-ActionRole.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Controller-ActionRole-0.14-1.fc14.src.rpm Description: This module allows to apply roles to the Catalyst::Actions for different controller methods. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2282078 *rt-0.10_01
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2282078 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) e11c23bf1643f78d754ee5c21bedacfbb11d161e Catalyst-Controller-ActionRole-0.14.tar.gz e11c23bf1643f78d754ee5c21bedacfbb11d161e ../SOURCES/Catalyst-Controller-ActionRole-0.14.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=14, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.65 cusr 0.08 csys = 1.77 CPU) + Package perl-Catalyst-Controller-ActionRole-0.14-1.fc14.noarch => Provides: perl(Catalyst::Controller::ActionRole) = 0.14 Requires: perl(Catalyst::Utils) perl(Class::MOP) perl(List::Util) perl(Moose) perl(Moose::Meta::Class) perl(MooseX::Types::Moose) perl(namespace::clean) perl(String::RewritePrefix) + Not a GUI application Suggestions: 1) you will resolve dependencies automatically so no need of following in spec Requires: perl(Catalyst::Runtime) >= 5.71001 Requires: perl(Class::MOP) >= 0.80 Requires: perl(Moose) >= 0.90 Requires: perl(String::RewritePrefix) >= 0.004 APPROVED.
New Package CVS Request ======================= Package Name: perl-Catalyst-Controller-ActionRole Short Description: Apply roles to action instances Owners: iarnell Branches: F-12 F-13 InitialCC: perl-sig
CVS done (by process-cvs-requests.py).
perl-Catalyst-Controller-ActionRole-0.14-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Catalyst-Controller-ActionRole-0.14-1.fc13
perl-Catalyst-Controller-ActionRole-0.14-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Catalyst-Controller-ActionRole-0.14-1.fc12
perl-Catalyst-Controller-ActionRole-0.14-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Catalyst-Controller-ActionRole'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Catalyst-Controller-ActionRole-0.14-1.fc13
perl-Catalyst-Controller-ActionRole-0.14-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Catalyst-Controller-ActionRole'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Catalyst-Controller-ActionRole-0.14-1.fc12
perl-Catalyst-Controller-ActionRole-0.14-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
perl-Catalyst-Controller-ActionRole-0.14-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.