Spec URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-View-Component-SubInclude.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-View-Component-SubInclude-0.09-1.fc14.src.rpm Description: Catalyst::View::Component::SubInclude allows you to include content in your templates (or, more generally, somewhere in your view's render processing) which comes from another action in your application. It's implemented as a Moose::Role, so using Moose in your view is required. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2282084 *rt-0.10_01
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2282084 + rpmlint outputfor SRPM and for RPM perl-Catalyst-View-Component-SubInclude.noarch: W: spelling-error Summary(en_US) subincludes -> sub includes, sub-includes, includes perl-Catalyst-View-Component-SubInclude.src: W: spelling-error Summary(en_US) subincludes -> sub includes, sub-includes, includes ==> this can be Ignored. + source files match upstream url (sha1sum) fc0fd434b2296d4a92ab2a3385d28a9d901eb029 Catalyst-View-Component-SubInclude-0.09.tar.gz fc0fd434b2296d4a92ab2a3385d28a9d901eb029 Catalyst-View-Component-SubInclude-0.09.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=5, 1 wallclock secs ( 0.01 usr 0.01 sys + 1.14 cusr 0.09 csys = 1.25 CPU) + Package perl-Catalyst-View-Component-SubInclude-0.09-1.fc14.noarch => Provides: perl(Catalyst::View::Component::SubInclude) = 0.09 perl(Catalyst::View::Component::SubInclude::ESI) = 0.07 perl(Catalyst::View::Component::SubInclude::SSI) = 0.09 perl(Catalyst::View::Component::SubInclude::SubRequest) = 0.07 perl(Catalyst::View::Component::SubInclude::Visit) = 0.07 Requires: perl(Carp) perl(Catalyst::Utils) perl(Class::MOP) perl(Moose) perl(Moose::Role) perl(MooseX::Types::Moose) perl(namespace::clean) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application Suggestions: 1) you don't need following in spec as yum will resolve it automatically Requires: perl(Catalyst::Plugin::SubRequest) Requires: perl(Catalyst::Runtime) >= 5.80014 Requires: perl(Moose) Requires: perl(Moose::Role) Requires: perl(MooseX::Types) Requires: perl(namespace::clean) APPROVED.
I do need those requires - none of them is picked up automatically.
New Package CVS Request ======================= Package Name: perl-Catalyst-View-Component-SubInclude Short Description: Use subincludes in your Catalyst views Owners: iarnell Branches: F-12 F-13 InitialCC: perl-sig
(In reply to comment #2) > I do need those requires - none of them is picked up automatically. Oops - I'm lying, obviously. Some of them can be removed: perl(Moose) perl(Moose::Role) perl(namespace::clean) The others may get pulled in by yum automatically due to current dependencies of other packages, but I'd rather state them explicitly.
CVS done (by process-cvs-requests.py).
We don't have a new enough Catalyst in F-13, so only built for rawhide.