Spec URL: http://kalev.fedorapeople.org/shiboken.spec SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-1.fc14.src.rpm Description: Shiboken is a bindings generator for C++ libraries that outputs CPython source code. It uses generatorrunner and apiextractor to collect information from library headers, merging modifications and handwritten code defined in the type system description. Shiboken is the binding generator used to create the PySide bindings.
BR: should state
(In reply to comment #1) > BR: should state shiboken-devel instead of shiboken.
(In reply to comment #2) > (In reply to comment #1) > > BR: should state > > shiboken-devel instead of shiboken. sorry, sparsehash-devel instead of sparsehash. Wanted: edit function to comments.
* Sat Jul 24 2010 Kalev Lember <kalev> - 0.3.2-2 - BR sparsehash-devel instead of sparsehash Spec URL: http://kalev.fedorapeople.org/shiboken.spec SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-2.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2348050
* Sat Jul 24 2010 Kalev Lember <kalev> - 0.3.2-3 - Require python2-devel in devel package as the public headers include Python.h Spec URL: http://kalev.fedorapeople.org/shiboken.spec SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-3.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2348060
Shiboken Review #### ? MUST: rpmlint must be run on every package. The output should be posted in the review. rpmlint -iv /var/lib/mock/fedora-13-x86_64/result/shiboken-*.rpm shiboken.src: I: checking shiboken.src: W: spelling-error Summary(en_US) CPython -> C Python, Python, Brython The value of this tag appears to be misspelled. Please double-check. shiboken.src: W: spelling-error %description -l en_US generatorrunner -> generator runner, generator-runner, generator The value of this tag appears to be misspelled. Please double-check. shiboken.src: W: spelling-error %description -l en_US apiextractor -> extractor, fluidextract, extraction The value of this tag appears to be misspelled. Please double-check. shiboken.src: I: checking-url http://www.pyside.org (timeout 10 seconds) shiboken.src: I: checking-url http://www.pyside.org/files/shiboken-0.3.2.tar.bz2 (timeout 10 seconds) shiboken.x86_64: I: checking shiboken.x86_64: W: spelling-error Summary(en_US) CPython -> C Python, Python, Brython The value of this tag appears to be misspelled. Please double-check. shiboken.x86_64: W: spelling-error %description -l en_US apiextractor -> extractor, fluidextract, extraction The value of this tag appears to be misspelled. Please double-check. shiboken.x86_64: I: checking-url http://www.pyside.org (timeout 10 seconds) shiboken.x86_64: W: no-manual-page-for-binary shiboken Each executable in standard binary directories should have a man page. shiboken-debuginfo.x86_64: I: checking shiboken-debuginfo.x86_64: I: checking-url http://www.pyside.org (timeout 10 seconds) shiboken-devel.x86_64: I: checking shiboken-devel.x86_64: I: checking-url http://www.pyside.org (timeout 10 seconds) shiboken-libs.x86_64: I: checking shiboken-libs.x86_64: W: spelling-error Summary(en_US) CPython -> C Python, Python, Brython The value of this tag appears to be misspelled. Please double-check. shiboken-libs.x86_64: W: spelling-error %description -l en_US generatorrunner -> generator runner, generator-runner, generator The value of this tag appears to be misspelled. Please double-check. shiboken-libs.x86_64: W: spelling-error %description -l en_US apiextractor -> extractor, fluidextract, extraction The value of this tag appears to be misspelled. Please double-check. shiboken-libs.x86_64: I: checking-url http://www.pyside.org (timeout 10 seconds) shiboken-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libshiboken.so.0.3.2 exit.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. 5 packages and 0 specfiles checked; 0 errors, 10 warnings. Spelling errors can be ignored. Not shure what to make of shared-lib-calls-exit, but it doesn't look good. + MUST: The package must be named according to the Package Naming Guidelines. + MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. + MUST: The package must meet the Packaging Guidelines. + MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. + MUST: The License field in the package spec file must match the actual license. + MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. + MUST: The spec file must be written in American English. + MUST: The spec file for the package MUST be legible. + MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. upstream: 802ecf28206aa17a9e3d64bf736c6470 src.rpm: 802ecf28206aa17a9e3d64bf736c6470 + MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. + MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. + MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. + MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. + MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. + MUST: Packages must NOT bundle copies of system libraries. + MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. + MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. + MUST: A Fedora package must not list a file more than once in the spec file's %files listings. + MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. + MUST: Each package must consistently use macros. + MUST: The package must contain code, or permissable content. + MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). + MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. + MUST: Header files must be in a -devel package. + MUST: Static libraries must be in a -static package. + MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. + MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. + MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. + MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. in %files %{_libdir}/generatorrunner/* <-- add generatorrunner as R + MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: Items marked as SHOULD are things that the package (or reviewer) SHOULD do, but is not required to do. + SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. + SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. + SHOULD: The reviewer should test that the package builds in mock. * SHOULD: The package should compile and build into binary rpms on all supported architectures. * SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. * SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. ? SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. Add Requires: %{name} = %{version}-%{release} to %package libs + SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. * SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. * SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.
(In reply to comment #6) > shiboken-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libshiboken.so.0.3.2 > exit.5 > This library package calls exit() or _exit(), probably in a non-fork() > context. Doing so from a library is strongly discouraged - when a library > function calls exit(), it prevents the calling program from handling the > error, reporting it to the user, closing files properly, and cleaning up any > state that the program has. It is preferred for the library to return an > actual error code and let the calling program decide how to handle the > situation. > > 5 packages and 0 specfiles checked; 0 errors, 10 warnings. > > Spelling errors can be ignored. > Not shure what to make of shared-lib-calls-exit, but it doesn't look good. I suspect rpmlint is just being stupid. libshiboken/typeresolver.cpp:70 contains the following line which probably triggers the rpmlint error: std::atexit(deinitTypeResolver); This is something all together different than calling exit() directly. > in %files > %{_libdir}/generatorrunner/* <-- add generatorrunner as R generatorrunner is already an implicit dependency: $ rpm -q --requires shiboken | grep gen libgenrunner.so.0.5 $ rpm -qf /usr/lib/libgenrunner.so.0.5 generatorrunner-0.5.0-2.fc14.i686 But yeah, I guess it's cleaner to also explicitly list generatorrunner dep. > ? SHOULD: Usually, subpackages other than devel should require the base package > using a fully versioned dependency. > > Add Requires: %{name} = %{version}-%{release} to %package libs No, it's the other way around in here: the main package has Requires: %{name}-libs = %{version}-%{release} The reason why libs are in a separate package is to avoid pulling in the whole shiboken main package (plus its long dep chain) for libraries which link against libshiboken; requiring main package from libs package would make the split meaningless. * Sat Jul 24 2010 Kalev Lember <kalev> - 0.3.2-4 - Explicitly require generatorrunner for %%{_libdir}/generatorrunner/ directory ownership (#609738) Spec URL: http://kalev.fedorapeople.org/shiboken.spec SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-4.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2348167
OK, I'm happy with that, approved.
Thanks a lot for the review, Magnus. Let me know if you need anything reviewed.
New Package CVS Request ======================= Package Name: shiboken Short Description: CPython bindings generator for C++ libraries Owners: kalev rdieter kkofler than ltinkl Branches: F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Imported and built, closing the ticket.
shiboken-0.3.2-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/shiboken-0.3.2-4.fc13
shiboken-0.3.2-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: shiboken New Branches: el6 Owners: than
Git done (by process-git-requests).
Package Change Request ====================== Package Name: shiboken New Branches: epel7 Owners: than jreznik ltinkl kkofler geertj rdieter