Spec URL: http://topdog-software.com/oss/SRPMS/fedora/dojo/dojo.spec SRPM URL: http://topdog-software.com/oss/SRPMS/fedora/dojo/dojo-1.4.3-1.fc13.src.rpm Description: Dojo is a JavaScript toolkit, providing cross-browser abstractions and widgets for building dynamic web sites.
*** Bug 455541 has been marked as a duplicate of this bug. ***
Created attachment 454077 [details] Spec file rebuilding dojo from sources The spec file you propose uses a preprocessed version of dojo. It does not rebuild it from the real sources. In hope that it can help you, please find a dojo spec file I wrote some times ago: it does rebuild dojo from sources. Do what you want with it.
Created attachment 454079 [details] Patch for the spec file in attachment 1 [details]
Created attachment 454082 [details] Apache configuration file for dojo. Used by the spec file in attachement 1
Updated spec and srpm http://www.topdog-software.com/oss/SRPMS/fedora/dojo/dojo-1.5.0-1.fc14.src.rpm http://www.topdog-software.com/oss/SRPMS/fedora/dojo/dojo.spec
Please update to 1.6.0. I'll then start the review.
Thanks Felix, Updated spec and srpm http://www.topdog-software.com/oss/SRPMS/fedora/dojo/dojo-1.6.0-1.fc14.src.rpm http://www.topdog-software.com/oss/SRPMS/fedora/dojo/dojo.spec
I would suggest: -Requires: httpd +Requires: webserver as you can have boa, lighthttpd... installed instead of httpd. ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including Web_Applications [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. tested in: f16/koji http://koji.fedoraproject.org/koji/taskinfo?taskID=3083333 [x] Rpmlint output: clean [x] Package is not relocatable. [x] Buildroot is correct %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 7ca8aa5a1db3ee1cabf414b2068ccdea ../SOURCES/dojo-release-1.6.0.tar.gz 7ca8aa5a1db3ee1cabf414b2068ccdea dojo-release-1.6.0.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. 1.6.0 [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: koji scratch build [x] Package should compile and build into binary rpms on all supported architectures. Tested on:koji scratch build [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the tests pass ================ *** NEED WORK *** ================ Fix the requires and it will be ok.
Hi Miroslav, If i use the webserver meta package, the package will not be useable when installed, Redhat does not have a configuration system like debconf which would setup the package for the user's installed webserver is that wise ?
Hmmm, yes you are right. And if I have installed boa, then the dir /etc/httpd/conf.d will does not exist .... I would say if somebody will have to use it with something else, he must install httpd and disable that service and manualy configure it for its own server. APPROVED
Miroslav, Thanks for the review, New Package SCM Request ======================= Package Name: dojo Short Description: Modular JavaScript toolkit Owners: topdog Branches: f13 f14 f15 el5 el6
Git done (by process-git-requests).
dojo-1.6.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/dojo-1.6.0-1.fc15
dojo-1.6.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/dojo-1.6.0-1.fc14
dojo-1.6.0-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/dojo-1.6.0-1.fc13
dojo-1.6.0-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/dojo-1.6.0-1.el5
dojo-1.6.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/dojo-1.6.0-1.el6
dojo-1.6.0-1.fc15 has been pushed to the Fedora 15 testing repository.
dojo-1.6.0-1.fc15 has been pushed to the Fedora 15 stable repository.
dojo-1.6.0-1.fc14 has been pushed to the Fedora 14 stable repository.
dojo-1.6.0-1.fc13 has been pushed to the Fedora 13 stable repository.
dojo-1.6.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository.
dojo-1.6.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
New Package SCM Request ======================= Package Name: dojo Short Description: Modular JavaScript toolkit Upstream URL: http://dojotoolkit.org/ Owners: topdog Branches: epel7 InitialCC: