Bug 610740
| Summary: | s-c-kickstart doesn't properly process partitioning when opening new file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Alexander Todorov <atodorov> | ||||
| Component: | system-config-kickstart | Assignee: | Chris Lumens <clumens> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Release Test Team <release-test-team-automation> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 6.0 | CC: | snagar, syeghiay | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | system-config-kickstart-2.6.8.3-1 | Doc Type: | Bug Fix | ||||
| Doc Text: |
When a user opened an existing file, Kickstart Configurator did not clear the partition information, and the configuration from the file was incorrectly added to the previous configuration. With this update, the underlying source code has been adapted to address this issue, and opening a file now clears the previous partition information as expected.
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 669360 (view as bug list) | Environment: | |||||
| Last Closed: | 2011-01-19 19:08:16 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. diff --git a/src/partition.py b/src/partition.py
index 575cb8e..ca50bd9 100644
--- a/src/partition.py
+++ b/src/partition.py
@@ -293,10 +293,11 @@ class partition:
self.initlabel_yes_radiobutton.set_active(True)
else:
self.initlabel_no_radiobutton.set_active(True)
-
else:
self.remove_parts_none_radiobutton.set_active(True)
+ self.part_store.clear()
+
for part in self.ks.partition.partitions:
self.partWindow.populateList(part)
With system-config-kickstart-2.8.6.3-1.el6.noarch when re-opening the same ks.cfg file again and again the previous partitions are cleared and new ones added. This doesn't cause duplication. Moving to VERIFIED.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
When a user opened an existing file, Kickstart Configurator did not clear the partition information, and the configuration from the file was incorrectly added to the previous configuration. With this update, the underlying source code has been adapted to address this issue, and opening a file now clears the previous partition information as expected.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0167.html |
Created attachment 429015 [details] screenshot of partitioning gone wrong Description of problem: When opening a file in s-c-kickstart the partitioning screen shows the current settings. When opening the same or another file this screen will append the new partitioning scheme to already existing one. After several reopenings user ends up with several definitions for the root filesystem. If saved this results in invalid ks.cfg Version-Release number of selected component (if applicable): system-config-kickstart-2.8.6.1-1.el6.noarch How reproducible: always Steps to Reproduce: 1. Install system-config-kickstart 2. Uncomment the partitioning lines in your /root/anaconda-ks.cfg 3. Open the file with s-c-kickstart. Observe the partitioning page. 4. Open the same file again. See screenshot. 5. Try opening it for the 3rd time. Actual results: The existing partitions are not cleared when opening new file and new ones are appended to the list. This produces invalid ks.cfg if saved. Check with "Preview". Expected results: Existing partitions are removed and new ones are added when opening new file (or the same one). Additional info: Upon filing this bug I've noticed that s-c-kickstart will not properly display the LVM VG and LVs. Only /boot and the PV are displayed. My ks.cfg has: bootloader --location=mbr --driveorder=sda --append="console=ttyS0,115200 crashkernel=auto" clearpart --all --initlabel part /boot --fstype=ext4 --size=500 part pv.Z6tsRr-yItL-6yIJ-fKFx-ZXd0-virq-eU81WE --grow --size=1 volgroup vg_tyangt2409 --pesize=4096 pv.Z6tsRr-yItL-6yIJ-fKFx-ZXd0-virq-eU81WE logvol /home --fstype=ext4 --name=lv_home --vgname=vg_tyangt2409 --grow --size=100 logvol / --fstype=ext4 --name=lv_root --vgname=vg_tyangt2409 --grow --size=1024 --maxsize=51200 logvol swap --name=lv_swap --vgname=vg_tyangt2409 --grow --size=1024 --maxsize=10128 Do you want me to open a separate bug for that?