Bug 611066 (perl-B-Compiling) - Review Request: perl-B-Compiling - Expose PL_compiling to perl
Summary: Review Request: perl-B-Compiling - Expose PL_compiling to perl
Status: CLOSED ERRATA
Alias: perl-B-Compiling
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/B-Compiling/
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-03 11:48 UTC by Iain Arnell
Modified: 2013-05-07 20:07 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2010-08-03 00:53:39 UTC
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2010-07-03 11:48:48 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-B-Compiling.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-B-Compiling-0.02-1.fc14.src.rpm

Description:
This module exposes the perl interpreter's PL_compiling variable to perl.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2291992

*rt-0.10_01

Comment 1 Parag AN(पराग) 2010-07-16 07:31:27 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2323514 
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
6a6d82747fbddb575f9729eb891ffbe8ab793123  B-Compiling-0.02.tar.gz
6a6d82747fbddb575f9729eb891ffbe8ab793123  B-Compiling-0.02.tar.gz.srpm

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=5,  1 wallclock secs ( 0.01 usr  0.02 sys +  0.06 cusr  0.02 csys =  0.11 CPU)
+ Package perl-B-Compiling-0.02-1.fc14.x86_64  =>
Provides: perl(B::Compiling) = 0.02
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) perl(B) perl(strict) perl(Sub::Exporter) perl(warnings) perl(XSLoader) rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH)

+ Not a GUI application

Suggestions
If package is imported for F-13 and above then please follow
1) buildroot should be removed
2) %clean not needed
3) cleaning of buildroot at start of %install also not needed 

APPROVED.

Comment 2 Iain Arnell 2010-07-16 08:06:13 UTC
New Package CVS Request
=======================
Package Name: perl-B-Compiling
Short Description: Expose PL_compiling to perl
Owners: iarnell
Branches: F-12 F-13
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2010-07-16 17:36:55 UTC
CVS done (by process-cvs-requests.py).

Comment 4 Fedora Update System 2010-07-17 05:54:54 UTC
perl-B-Compiling-0.02-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-B-Compiling-0.02-2.fc13

Comment 5 Fedora Update System 2010-07-17 05:55:00 UTC
perl-B-Compiling-0.02-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-B-Compiling-0.02-1.fc12

Comment 6 Iain Arnell 2010-07-17 05:59:16 UTC
Imported to rawhide and F-13 with a modernized spec.

Thanks for the review.

Comment 7 Fedora Update System 2010-08-03 00:53:35 UTC
perl-B-Compiling-0.02-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2010-08-03 01:13:55 UTC
perl-B-Compiling-0.02-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Andrea Veri 2013-05-07 19:49:46 UTC
Package Change Request
======================
Package Name: perl-B-Compiling
New Branches: el6
Owners: averi psabata
InitialCC: perl-sig

Comment 10 Gwyn Ciesla 2013-05-07 20:07:52 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.