612110 – rgmanager initscript FedoraGuidelines compliance

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 612110 - rgmanager initscript FedoraGuidelines compliance

Summary: rgmanager initscript FedoraGuidelines compliance

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	rgmanager
Sub Component:
Version:	6.0
Hardware:	All
OS:	Linux
Priority:	high
Severity:	medium
Target Milestone:	rc
Target Release:	---
Assignee:	Fabio Massimo Di Nitto
QA Contact:	Cluster QE
Docs Contact:
URL:
Whiteboard:
Depends On:	537506
Blocks:	633349
TreeView+	depends on / blocked

Reported:	2010-07-07 10:38 UTC by Fabio Massimo Di Nitto
Modified:	2010-11-10 22:16 UTC (History)
CC List:	6 users (show)
Fixed In Version:	rgmanager-3.0.12-7.el6
Doc Type:	Bug Fix
Doc Text:
Clone Of:	537506
Environment:
Last Closed:	2010-11-10 22:16:31 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Description Fabio Massimo Di Nitto 2010-07-07 10:38:39 UTC

+++ This bug was initially created as a clone of Bug #537506 +++

Description of problem:

This is a list of issues for the rgmanager init script when compared with the
criteria in 
https://fedoraproject.org/wiki/Packaging/SysVInitScript


Version-Release number of selected component (if applicable):
rgmanager-3.0.4-1.fc12.i686

* try-restart command is not implemented (should be same as condrestart)

* condrestart implementation is the same as restart

* wrong exit status on usage and with invalid argument.  Got 1, expected 2.

[root@morph-04 tmp]$ service rgmanager
usage: /etc/init.d/rgmanager {start|restart|condrestart|reload|status|stop}
[root@morph-04 tmp]$ echo $?
1
[root@morph-04 tmp]$ service rgmanager badarg
usage: /etc/init.d/rgmanager {start|restart|condrestart|reload|status|stop}
[root@morph-04 tmp]$ echo $?
1

--- Additional comment from fedora-triage-list on 2009-11-16 10:31:41 EST ---


This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

--- Additional comment from fdinitto on 2009-11-24 01:52:55 EST ---

Fixed with commit df7a30d84a4f8b9b645bdef52731491e60e590b8 in STABLE3

Comment 1 Fabio Massimo Di Nitto 2010-07-07 10:40:37 UTC

Further testing revealed one more unsolved issues to be LSB complaint.

d08e3bec8a853ef84a24fa4b86528718fa7e169e upstream commit

Comment 2 Fabio Massimo Di Nitto 2010-07-07 10:43:52 UTC

:: [   LOG    ] :: Assertions: 27 good, 0 bad

for the record.

Comment 5 Nate Straz 2010-07-16 20:05:57 UTC

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: TEST PROTOCOL
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   LOG    ] :: Test run ID   : debugging
:: [   LOG    ] :: Package       : rgmanager
:: [   LOG    ] :: Installed:    : rgmanager-3.0.12-10.el6.x86_64
:: [   LOG    ] :: Test started  : 2010-07-16 16:04:40
:: [   LOG    ] :: Test finished : 2010-07-16 16:05:23
:: [   LOG    ] :: Test name     :
:: [   LOG    ] :: Distro:       : Red Hat Enterprise Linux Server release 6.0 Beta (Santiago)
:: [   LOG    ] :: Hostname      : west-04.lab.bos.redhat.com
:: [   LOG    ] :: Architecture  : x86_64

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: Test description
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

Cannot find the PURPOSE file of this test. Could be a missing, or
rlInitializeJournal wasn't called from appropriate location

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: Test
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   LOG    ] :: >>>>>>>>> service start
:: [   PASS   ] ::  Service must start without problem
:: [   PASS   ] ::  Then Status command
:: [   PASS   ] ::  Already started service
:: [   PASS   ] ::  Again status command
:: [   LOG    ] :: >>>>>>>>> service restart
:: [   PASS   ] ::  Restarting of service
:: [   PASS   ] ::  Status command
:: [   LOG    ] :: >>>>>>>>> service stop
:: [   PASS   ] ::  Stopping service
:: [   PASS   ] ::  Status of stopped service
:: [   PASS   ] ::  Stopping service again
:: [   PASS   ] ::  Status of stopped service
:: [   LOG    ] :: >>>>>>>>> pid file
:: [   PASS   ] :: File /var/run/rgmanager.pid should exist
:: [   PASS   ] :: Running 'echo 666666 > /var/run/rgmanager.pid'
:: [   PASS   ] ::  Existing pid file, but service not started
:: [   LOG    ] :: >>>>>>>>> lock file
:: [   PASS   ] :: File /var/lock/subsys/rgmanager should exist
:: [   PASS   ] :: Running 'touch /var/lock/subsys/rgmanager'
:: [   PASS   ] ::  Existing lock file, but service not started
:: [   LOG    ] :: >>>>>>>>> insufficient rights
:: [   PASS   ] ::  Starting service for restarting under nonpriv user
:: [   PASS   ] :: Insufficient rights, restarting resrvice under nonprivileged user must fail
:: [   LOG    ] :: >>>>>>>>> operations
:: [   PASS   ] ::  Service have to implement start function
:: [   PASS   ] ::  Service have to implement restart function
:: [   PASS   ] ::  Service have to implement status function
:: [   PASS   ] ::  Service have to implement condrestart function
:: [   PASS   ] ::  Service have to implement try-restart function
:: [   PASS   ] ::  Service have to implement reload function
:: [   PASS   ] ::  Service have to implement force-reload function
:: [   LOG    ] :: >>>>>>>>> nonexist operations
:: [   PASS   ] ::  Testing proper return code when nonexisting function
:: [   LOG    ] :: >>>>>>>>> invalid arguments
:: [   PASS   ] ::  When no arguments added to service, it must fail with proper return code
:: [   LOG    ] :: Duration: 43s
:: [   LOG    ] :: Assertions: 27 good, 0 bad
:: [   PASS   ] :: RESULT: Test

Comment 6 releng-rhel@redhat.com 2010-11-10 22:16:31 UTC

Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.

Note You need to log in before you can comment on or make changes to this bug.