fix coverity Defect Type: Null pointer dereferences issues 11892 - 11939
Created attachment 430784 [details] 0001-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430785 [details] 0002-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430786 [details] 0003-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430787 [details] 0004-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430788 [details] 0005-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430789 [details] 0006-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430790 [details] 0007-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430791 [details] 0008-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430792 [details] 0009-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430793 [details] 0010-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430794 [details] 0011-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430796 [details] 0012-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430797 [details] 0013-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430798 [details] 0014-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430799 [details] 0015-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430800 [details] 0016-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430801 [details] 0017-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430802 [details] 0018-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430804 [details] 0019-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430805 [details] 0020-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430806 [details] 0021-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430807 [details] 0022-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430808 [details] 0023-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430809 [details] 0024-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430810 [details] 0025-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430811 [details] 0026-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430812 [details] 0027-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430815 [details] 0028-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430816 [details] 0029-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430817 [details] 0030-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Created attachment 430818 [details] 0031-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch
Comment on attachment 430784 [details] 0001-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11892&streamDefectId=12078&defectInstanceId=13942&fileInstanceId=49545
Comment on attachment 430785 [details] 0002-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11894&streamDefectId=12080&defectInstanceId=13944&fileInstanceId=49552
Comment on attachment 430786 [details] 0003-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11895&streamDefectId=12081&defectInstanceId=13945&fileInstanceId=49556
Comment on attachment 430787 [details] 0004-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11896&streamDefectId=12082&defectInstanceId=13946&fileInstanceId=49287
Comment on attachment 430788 [details] 0005-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11897&streamDefectId=12083&defectInstanceId=13947&fileInstanceId=49560 Note: removing if (notify) check from inside of the do loop is okay since it's guaranteed to be non-NULL at the first round "head != NULL".
Comment on attachment 430789 [details] 0006-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch We should check the NULL value before and after the normalization. ("after-check" is needed only when normalization is executed.) @@ -330,9 +330,14 @@ value_cmp( } } + if ( !v1->bv_val || !v2->bv_val ) { + LDAPDebug(LDAP_DEBUG_PLUGIN, "missing value\n", 0, 0, 0); + goto done; + } + if (syntax & SYNTAX_INT) { Also, the return value (rc) should be something like this (since it's a function to compare values and there's no "error return"): if (v1->bv_val) { if (!v2->bv_val) { rc = 1; goto done; } } else { if (v2->bv_val) { rc = -1; goto done; } else { rc = 0; goto done; } }
Comment on attachment 430812 [details] 0027-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11900&streamDefectId=12086&defectInstanceId=13950&fileInstanceId=49063
Comment on attachment 430790 [details] 0007-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch Rather, I'd like to change slapi_free_search_results_internal to accept NULL pblock. (note: slapi_pblock_destroy already does that) Also, the problem is not the return value from slapi_pblock_new, but there is a chance to jump to bail before assigning non-NULL value to search_pb. Another note: as long as using slapi_ch_*alloc, DS never gets NULL from *alloc functions. It does exit. diff --git a/ldap/servers/slapd/plugin_internal_op.c b/ldap/servers/slapd/plugin index 2707149..e13d796 100644 --- a/ldap/servers/slapd/plugin_internal_op.c +++ b/ldap/servers/slapd/plugin_internal_op.c @@ -463,7 +463,11 @@ void slapi_free_search_results_internal(Slapi_PBlock *pb) { int i; - + + if (NULL == pb) { + return; + } + if(pb->pb_plugin_internal_search_op_entries != NULL) { for(i=0; pb->pb_plugin_internal_search_op_entries[i] != NULL; i++)
Comment on attachment 430806 [details] 0021-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch If you "goto free_and_return", it should be done after "ctrls" is initialized. Instead, you could just "return LDAP_OPERATIONS_ERROR" there. + if (!pb) { + LDAPDebug( LDAP_DEBUG_ANY, "get_ldapmessage_controls: NULL PBlock\n", 0, 0, 0 ); + rc = LDAP_OPERATIONS_ERROR; /* unexpected error */ + goto free_and_return; + } +
Comment on attachment 430791 [details] 0008-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch Overall, the patch looks good. Please use slapi_ch_free_string instead of "if (subject) free (subject);" 562 done: 563 if (subject) free (subject); ==> 564 slapi_ch_free_string(&subject);
Comment on attachment 430793 [details] 0010-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11905&streamDefectId=12091&defectInstanceId=13955&fileInstanceId=49296
Comment on attachment 430797 [details] 0013-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch Please put the error check after PR_ASSERT. The author believes foreman never gets NULL. If we build the server with debugging enabled, the server quits if the assertion fails. This is needed for debugging. @@ -703,6 +703,10 @@ static int import_monitor_threads(ImportJob *job, int *status) if (job->flags & FLAG_USE_FILES) PR_ASSERT(producer != NULL); PR_ASSERT(foreman != NULL); + + if (!foreman) { + goto error_abort; + }
Comment on attachment 430804 [details] 0019-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11909&streamDefectId=12095&defectInstanceId=13959&fileInstanceId=49351
Comment on attachment 430799 [details] 0015-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11910&streamDefectId=12096&defectInstanceId=13960&fileInstanceId=49321
Comment on attachment 430802 [details] 0018-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11911&streamDefectId=12097&defectInstanceId=13961&fileInstanceId=49336
Comment on attachment 430792 [details] 0009-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11912&streamDefectId=12098&defectInstanceId=13962&fileInstanceId=49289
Comment on attachment 430792 [details] 0009-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11913&streamDefectId=12099&defectInstanceId=13963&fileInstanceId=49289
Comment on attachment 430792 [details] 0009-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11915&streamDefectId=12101&defectInstanceId=13965&fileInstanceId=49289
Comment on attachment 430794 [details] 0011-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11917&streamDefectId=12103&defectInstanceId=13967&fileInstanceId=49303
Comment on attachment 430798 [details] 0014-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11917&streamDefectId=12103&defectInstanceId=13967&fileInstanceId=49303 This patch itself is good. But, sorry, now the caller of index_index2prefix should take care of the possibility of NULL return from index_index2prefix.
Comment on attachment 430796 [details] 0012-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11919&streamDefectId=12105&defectInstanceId=13969&fileInstanceId=49315
Comment on attachment 430807 [details] 0022-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11920&streamDefectId=12106&defectInstanceId=13970&fileInstanceId=48981
Comment on attachment 430796 [details] 0012-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11921&streamDefectId=12107&defectInstanceId=13971&fileInstanceId=49315
Comment on attachment 430800 [details] 0016-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11922&streamDefectId=12108&defectInstanceId=13972&fileInstanceId=49324
Comment on attachment 430801 [details] 0017-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11923&streamDefectId=12109&defectInstanceId=13973&fileInstanceId=49327
Comment on attachment 430805 [details] 0020-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11924&streamDefectId=12110&defectInstanceId=13974&fileInstanceId=49354
Comment on attachment 430812 [details] 0027-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11925&streamDefectId=12111&defectInstanceId=13975&fileInstanceId=49063
Comment on attachment 430804 [details] 0019-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11926&streamDefectId=12112&defectInstanceId=13976&fileInstanceId=49351
Comment on attachment 430808 [details] 0023-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11927&streamDefectId=12113&defectInstanceId=13977&fileInstanceId=48998
Comment on attachment 430809 [details] 0024-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11928&streamDefectId=12114&defectInstanceId=13978&fileInstanceId=49676
Comment on attachment 430810 [details] 0025-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11930&streamDefectId=12116&defectInstanceId=13980&fileInstanceId=49046
Comment on attachment 430810 [details] 0025-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11931&streamDefectId=12117&defectInstanceId=13981&fileInstanceId=49046
Comment on attachment 430815 [details] 0028-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11932&streamDefectId=12118&defectInstanceId=13982&fileInstanceId=49083
Comment on attachment 430815 [details] 0028-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11933&streamDefectId=12119&defectInstanceId=13983&fileInstanceId=49083
Comment on attachment 430816 [details] 0029-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11934&streamDefectId=12120&defectInstanceId=13985&fileInstanceId=49111 Why don't we change destroy_task, instead? diff --git a/ldap/servers/slapd/task.c b/ldap/servers/slapd/task.c index a7fe789..a39c70d 100644 --- a/ldap/servers/slapd/task.c +++ b/ldap/servers/slapd/task.c @@ -540,6 +540,10 @@ destroy_task(time_t when, void *arg) Slapi_Task *t1; Slapi_PBlock *pb = slapi_pblock_new(); + if (NULL == task) { + return; + } + /* Call the custom destructor callback if one was provided, * then perform the internal task destruction. */ if (task->destructor != NULL) {
Comment on attachment 430816 [details] 0029-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11935&streamDefectId=12121&defectInstanceId=13986&fileInstanceId=49111 Note: @@ -1737,7 +1737,14 @@ task_upgradedb_add(Slapi_PBlock *pb, Slapi_Entry *e, Slapi_Entry *eAfter, is good
Comment on attachment 430817 [details] 0030-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11936&streamDefectId=12122&defectInstanceId=13987&fileInstanceId=49607
Comment on attachment 430818 [details] 0031-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11939&streamDefectId=12125&defectInstanceId=13990&fileInstanceId=49700
Comment on attachment 430811 [details] 0026-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11929&streamDefectId=12115&defectInstanceId=13979&fileInstanceId=49676
(In reply to comment #41) Never mind the suggestion I made for slapi_free_search_results_internal. You already fixed in the patch 0026. Still, you don't need the patch 0007 since slapi_pblock_new never returns NULL. > (From update of attachment 430790 [details]) > Rather, I'd like to change slapi_free_search_results_internal to accept NULL > pblock. (note: slapi_pblock_destroy already does that) > > Also, the problem is not the return value from slapi_pblock_new, but there is a > chance to jump to bail before assigning non-NULL value to search_pb. > > Another note: as long as using slapi_ch_*alloc, DS never gets NULL from *alloc > functions. It does exit. > > diff --git a/ldap/servers/slapd/plugin_internal_op.c > b/ldap/servers/slapd/plugin > index 2707149..e13d796 100644 > --- a/ldap/servers/slapd/plugin_internal_op.c > +++ b/ldap/servers/slapd/plugin_internal_op.c > @@ -463,7 +463,11 @@ void > slapi_free_search_results_internal(Slapi_PBlock *pb) > { > int i; > - > + > + if (NULL == pb) { > + return; > + } > + > if(pb->pb_plugin_internal_search_op_entries != NULL) > { > for(i=0; pb->pb_plugin_internal_search_op_entries[i] != NULL; i++)
Comment on attachment 430811 [details] 0026-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11877&streamDefectId=12063&defectInstanceId=13926&fileInstanceId=49603
Comment on attachment 430811 [details] 0026-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11878&streamDefectId=12064&defectInstanceId=13927&fileInstanceId=49603
Created attachment 439156 [details] 0006a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch The patch has been modified to check for NULL values before and after normalization.
Created attachment 439157 [details] 0008a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch The patch has been modified to call slapi_ch_free_string(&subject).
Created attachment 439159 [details] 0013a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch The patch has been modified to check the NULL value after PR_ASSERT().
Created attachment 439160 [details] 0014a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch The patch has been modified to handle the NULL return value from index_index2prefix().
Created attachment 439163 [details] 0021a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch The patch has been modified to return immediately when a NULL pointer error occurs.
Created attachment 439164 [details] 0029a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch The destroy_task() has been modified to handle NULL task.
Comment on attachment 439156 [details] 0006a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030&mergedDefectIds=11898#mergedDefectId=11898&streamDefectId=12084&defectInstanceId=13948&fileInstanceId=49583
Comment on attachment 439157 [details] 0008a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11904&streamDefectId=12090&defectInstanceId=13954&fileInstanceId=49660
Comment on attachment 439159 [details] 0013a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11908&streamDefectId=12094&defectInstanceId=13958&fileInstanceId=49311
Comment on attachment 439163 [details] 0021a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11903&streamDefectId=12089&defectInstanceId=13953&fileInstanceId=48973
Comment on attachment 439164 [details] 0029a-Bug-613056-fix-coverify-Defect-Type-Null-pointer-der.patch http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11934&streamDefectId=12120&defectInstanceId=13985&fileInstanceId=49111
On behalf of Endi (edewata), pushed to master. $ git merge endi Updating 634c7aa..10d4035 Fast-forward .../plugins/replication/windows_protocol_util.c | 11 +++++- ldap/servers/plugins/retrocl/retrocl_po.c | 7 +++- ldap/servers/plugins/roles/roles_cache.c | 2 +- ldap/servers/plugins/statechange/statechange.c | 7 ++-- ldap/servers/plugins/syntaxes/value.c | 26 +++++++++++++- ldap/servers/slapd/auth.c | 23 ++++++++----- ldap/servers/slapd/back-ldbm/archive.c | 6 ++-- ldap/servers/slapd/back-ldbm/dblayer.c | 35 +++++++++++-------- ldap/servers/slapd/back-ldbm/filterindex.c | 6 +++- ldap/servers/slapd/back-ldbm/import.c | 5 +++ ldap/servers/slapd/back-ldbm/index.c | 32 +++++++++++++++-- ldap/servers/slapd/back-ldbm/ldbm_attr.c | 7 ++++ .../slapd/back-ldbm/ldbm_attrcrypt_config.c | 2 +- ldap/servers/slapd/back-ldbm/ldbm_config.c | 1 + ldap/servers/slapd/back-ldbm/ldif2ldbm.c | 2 +- ldap/servers/slapd/back-ldbm/vlv_srch.c | 2 +- ldap/servers/slapd/control.c | 7 +++- ldap/servers/slapd/dn.c | 5 +++ ldap/servers/slapd/filter.c | 2 +- ldap/servers/slapd/main.c | 34 +++++++++++-------- ldap/servers/slapd/mapping_tree.c | 8 ++-- ldap/servers/slapd/plugin_internal_op.c | 5 +++ ldap/servers/slapd/plugin_syntax.c | 36 +++++++++---------- ldap/servers/slapd/schema.c | 8 +++- ldap/servers/slapd/task.c | 15 +++++++- ldap/servers/slapd/tools/dbscan.c | 7 +++- ldap/servers/snmp/main.c | 4 ++ 27 files changed, 216 insertions(+), 89 deletions(-) $ git push Counting objects: 218, done. Delta compression using up to 4 threads. Compressing objects: 100% (178/178), done. Writing objects: 100% (178/178), 17.92 KiB, done. Total 178 (delta 149), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 634c7aa..10d4035 master -> master
Coverity Related, Can I request dev to please test this.