http://mclasen.fedorapeople.org/fillmore.spec http://mclasen.fedorapeople.org/fillmore-0.1.0-1.fc14.src.rpm
Initial comments here: 1.rpmlint fill*rpm fillmore.src: W: spelling-error Summary(en_US) multitrack -> multitask, multiracial, multitude fillmore.src: W: spelling-error %description -l en_US multitrack -> multitask, multiracial, multitude fillmore.src: W: non-standard-group Unspecified fillmore.src:33: W: configure-without-libdir-spec fillmore.src: W: no-cleaning-of-buildroot %clean fillmore.src: W: no-buildroot-tag fillmore.src: W: no-%clean-section fillmore.x86_64: W: spelling-error Summary(en_US) multitrack -> multitask, multiracial, multitude fillmore.x86_64: W: spelling-error %description -l en_US multitrack -> multitask, multiracial, multitude fillmore.x86_64: W: non-standard-group Unspecified fillmore.x86_64: W: no-manual-page-for-binary fillmore fillmore.x86_64: E: invalid-desktopfile /usr/share/applications/fillmore.desktop value "application/fillmore;text/yorba-media" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character fillmore-lombard.x86_64: W: non-standard-group Unspecified fillmore-lombard.x86_64: W: no-manual-page-for-binary lombard fillmore-lombard.x86_64: E: invalid-desktopfile /usr/share/applications/lombard.desktop value "application/lombard;text/yorba-media" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character 4 packages and 0 specfiles checked; 2 errors, 13 warnings. invalid-desktopfile errors and non-standard-group Unspecified warnings should be fixed. 2. Missing mimeinfo scripts in spec https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo 3. Package name don't match naming guideline: fillmore can be renamed to fillmore-lombard, then create to two independent subpackages, fillmore and lombard are two seperate softwares. %package -n fillmore %package -n lombard 4. Spec don't honor compiler flags(%{optflags}) correctly From koji log: cc -c `pkg-config --cflags gee-1.0 gdk-x11-2.0 gstreamer-0.10 gstreamer-base-0.10 gstreamer-controller-0.10 gstreamer-interfaces-0.10 gstreamer-pbutils-0.10 gtk+-2.0` -I../../vapi -D_VERSION='"0.1.0"' -D_PREFIX='"/usr"' -O2 -g -pipe -fPIC -o marina/ui_clip.o marina/ui_clip.c
Not sure the independent subpackages are really better, but here you go: http://mclasen.fedorapeople.org/fillmore-lombard.spec http://mclasen.fedorapeople.org/fillmore-lombard-0.1.0-2.fc14.src.rpm
(In reply to comment #2) > Not sure the independent subpackages are really better, but here you go: > http://mclasen.fedorapeople.org/fillmore-lombard.spec > http://mclasen.fedorapeople.org/fillmore-lombard-0.1.0-2.fc14.src.rpm It seems like fillmore and lombard are seperate softwares, lombard is not a subpackage of fillmore and the vice versa, so I think use fillmore and lombard for rpm name will be better. review here +:ok, =:needs attention, -:needs fixing MUST Items: [-] MUST: rpmlint must be run on every package. [=] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name} [+] MUST: The package must meet the Packaging Guidelines. [FIXME?: covers this list and more] [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. <<md5sum checksum>>ac2d7d1549f7230853b3539bcd362eb8 [-] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. [+] MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissible content. This is described in detail in the code vs. content section of Packaging Guidelines. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. Some minor issue here: 1.%package fillmore should be changed to %package -n fillmore, so that we can use fillmore as a binary rpm name. %package lombard should be changed to %package -n lombard also. 2. All Subpackages need to add Group: Applications/Multimedia to avoid non-standard-group Unspecified warnings in rpmlint. 3. koji build on x86_64 is failed now(i686 is fine). See http://koji.fedoraproject.org/koji/taskinfo?taskID=2318335
http://mclasen.fedorapeople.org/fillmore-lombard.spec http://mclasen.fedorapeople.org/fillmore-lombard-0.1.0-3.fc14.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321685
Okay, the package is approved.
New Package CVS Request ======================= Package Name: fillmore-lombard Short Description: audio and video editors for GNOME Owners: mclasen Branches: InitialCC:
CVS done (by process-cvs-requests.py).
built