Bug 614008 - Review Request: perl-File-FcntlLock - Perl module for file locking with fcntl
Review Request: perl-File-FcntlLock - Perl module for file locking with fcntl
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Mark Chappell
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-13 09:31 EDT by Tom "spot" Callaway
Modified: 2010-07-13 11:52 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-07-13 11:52:30 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tremble: fedora‑review+
tcallawa: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2010-07-13 09:31:58 EDT
Spec URL: http://www.auroralinux.org/people/spot/review/new/perl-File-FcntlLock.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/perl-File-FcntlLock-0.12-1.fc13.src.rpm
Description: 
FcntlLock is a module to do file locking in an object oriented
fashion using the fcntl(2) system call. This allows locks on parts
of a file as well as on the whole file and overcomes some known
problems with flock(2), on which Perl's flock() function is based.

Rawhide Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2316385

Note: This is a new dependency for perl-Mail-Box.
Comment 1 Mark Chappell 2010-07-13 10:03:29 EDT
 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [/] Package meets the Packaging Guidelines including the Perl specific items
  [/] Versioned MODULE_COMPAT_ Requires
  [/] Non-Versioned CPAN URL tag
 [/] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: https://koji.fedoraproject.org/koji/taskinfo?taskID=2316397
 [/] Rpmlint output:
  perl-File-FcntlLock.src: W: spelling-error Summary(en_US) fcntl -> cantle, scantly, fluently
  perl-File-FcntlLock.src: W: spelling-error %description -l en_US fcntl -> cantle, scantly, fluently
  perl-File-FcntlLock.src: W: no-cleaning-of-buildroot %clean
  perl-File-FcntlLock.src: W: no-buildroot-tag
  perl-File-FcntlLock.src: W: no-%clean-section
  perl-File-FcntlLock.x86_64: W: spelling-error Summary(en_US) fcntl -> cantle, scantly, fluently
  perl-File-FcntlLock.x86_64: W: spelling-error %description -l en_US fcntl -> cantle, scantly, fluently
 [/] Package is not relocatable.
 [/] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [/] License field in the package spec file matches the actual license. 
     License type: GPL+ or Artistic (Standard Perl License)
 [/] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [/] Spec file is legible and written in American English.
 [/] Sources used to build the package matches the upstream source, as provided in the spec URL.
    ee75374c6f1a9db2bca92d3a396f748e  File-FcntlLock-0.12.tar.gz
    ee75374c6f1a9db2bca92d3a396f748e  File-FcntlLock-0.12.tar.gz.1
 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [/] Package must own all directories that it creates.
 [/] Package requires other packages for directories it uses.
 [/] Package does not contain duplicates in %files.
 [/] Permissions on files are set properly.
 [/] Package consistently uses macros.
 [/] Package contains code, or permissible content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [/] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [/] Latest version is packaged.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [/] Reviewer should test that the package builds in mock.
     Tested on: https://koji.fedoraproject.org/koji/taskinfo?taskID=2316397
 [/] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: fedora-rawhide x86_64 and i686
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [/] %check is present and the tests pass
All tests successful.
Files=1, Tests=11,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.03 cusr  0.00 csys =  0.05 CPU)
Result: PASS

=== COMMENTS ===

The rpmlint warnings are as I understand it out of date for F-13+ (missing sections), or false positives (spelling)

package APPROVED
Comment 2 Tom "spot" Callaway 2010-07-13 10:12:03 EDT
New Package CVS Request
=======================
Package Name: perl-File-FcntlLock
Short Description: Perl module for file locking with fcntl
Owners: spot
Branches: EL-5 EL-6 F-12 F-13 devel
InitialCC: perl-sig
Comment 3 Tom "spot" Callaway 2010-07-13 11:42:05 EDT
CVS done (by process-cvs-requests.py).
Comment 4 Tom "spot" Callaway 2010-07-13 11:52:30 EDT
Built in EL-6 and devel, other branches were "just in case".

Thanks for the quick review!

Note You need to log in before you can comment on or make changes to this bug.