Bug 614541 - Review Request: Django-loki - Web interface to manage buildbots
Summary: Review Request: Django-loki - Web interface to manage buildbots
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-14 17:47 UTC by Dan Radez
Modified: 2013-10-19 14:42 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2011-11-09 14:24:10 UTC
mmahut: fedora-review?


Attachments (Terms of Use)

Description Dan Radez 2010-07-14 17:47:41 UTC
Spec URL: http://radez.fedorapeople.org/loki.spec
SRPM URL: http://radez.fedorapeople.org/Django-loki-0.7.2-1.fc13.src.rpm
Description: A django interface to managagine buildbots

This is my first package and I need a sponsor

Comment 1 Anderson Silva 2010-07-14 18:07:43 UTC
Django-reusable-base requirement isn't a fedora package it seems, at least it is not found when I try to do a yum install on it.

Comment 2 Dan Radez 2010-07-14 18:17:52 UTC
working with a sponsor in person. updated a few things in teh spec. updated comments, and requires

Comment 3 Anderson Silva 2010-07-14 18:36:29 UTC
it passes rpm lint, but building the rpm fails with:

Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/remote/ansilva/rpmbuild/BUILDROOT/Django-loki-0.7.2-1.fc13.i386
error: Installed (but unpackaged) file(s) found:
   /usr/lib/python2.6/site-packages/Django_loki-0.7.2-py2.6.egg-info


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib/python2.6/site-packages/Django_loki-0.7.2-py2.6.egg-info

Comment 4 Dan Radez 2010-07-14 18:42:08 UTC
updated spec,
new srpm link:
http://radez.fedorapeople.org/Django-loki-0.7.2-2.fc13.src.rpm

Comment 5 Anderson Silva 2010-07-14 18:49:27 UTC
spec and src looks reasonable.

Comment 6 Anderson Silva 2010-07-14 18:49:49 UTC
(In reply to comment #5)
> spec and src looks reasonable.    

... look ...

Comment 7 Dan Radez 2010-07-14 20:25:47 UTC
Still need a sponsor for this. Anderson was not able to sponsor me after all. We're learning how sponsorship works :)

Comment 8 Kevin Fenzi 2010-07-15 19:37:21 UTC
Hey Dan. ;) 

Some general comments here before a full review: 

- Take a look at http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored 
If you have some more packages to submit and/or wish to do some 'pre reviews' of other pending reviews to show you know the guidelines, that would be great. 

- Your spec file should match the package name. Please make sure it's "Django-loki.spec" and not just "loki.spec"

- Please see: https://fedoraproject.org/wiki/Packaging:Python_Eggs about the egg files. You shouldn't ghost them, but should provide them. Also, might check over the main python guidelines: 
https://fedoraproject.org/wiki/Packaging:Python

Please update those things and I will look at doing a formal review. ;)

Comment 9 Dan Radez 2010-07-16 13:58:10 UTC
Spec URL: http://radez.fedorapeople.org/Django-loki.spec
SRPM URL: http://radez.fedorapeople.org/Django-loki-0.7.2-2.fc13.src.rpm
Description: A django interface to managaing buildbots

updated this info.

Comment 10 Dan Radez 2010-07-16 14:15:16 UTC
Kevin,
The updates have been made as requested. I do have one other package to submit. I'll get this one ready too and work through some pre reviews.

Thanks

Dan

Comment 11 Kevin Fenzi 2010-07-17 04:04:25 UTC
Marek: Were you going to review this and look at sponsoring Dan? 

I'd be happy to do so, or you can... I didn't note that you had assigned the review already. :)

Comment 12 Dan Radez 2011-11-09 14:24:10 UTC
not going to continue trying to package this


Note You need to log in before you can comment on or make changes to this bug.