Bug 614619 - 'maintenance' - what's that?
Summary: 'maintenance' - what's that?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: systemd
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Lennart Poettering
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-14 21:18 UTC by Bill Nottingham
Modified: 2014-03-17 03:24 UTC (History)
6 users (show)

Fixed In Version: initscripts-9.20-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-14 23:22:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
changes "maintenance" to "failed" throughout (45.38 KB, patch)
2010-08-26 20:07 UTC, Matthew Miller
no flags Details | Diff
patch to change 'maintenance' to 'failed' (47.61 KB, patch)
2010-08-26 20:38 UTC, Matthew Miller
no flags Details | Diff

Description Bill Nottingham 2010-07-14 21:18:27 UTC
Description of problem:

# systemctl | grep maint
cpuspeed.service                              loaded maintenance  maintenance 
rpcgssd.service                               loaded maintenance  maintenance 

It's in red, so it must be important. Don't see it documented anywhere obvious in the man pages, though.

Version-Release number of selected component (if applicable):

systemd-3-3

Comment 1 Bill Nottingham 2010-07-14 21:19:01 UTC
Also, systemctl doesn't disable the color when it's talking to a pipe... it should.

Comment 2 Orion Poplawski 2010-07-16 22:55:01 UTC
Services appear to go into maintenance when startup fails:

systemd[1]: Got SIGCHLD for process 693 (ip6tables)
systemd[1]: Child 693 died (code=exited, status=6/NOTCONFIGURED)
systemd[1]: Child 693 belongs to ip6tables.service
systemd[1]: ip6tables.service: control process exited, code=exited status=6
systemd[1]: ip6tables.service got final SIGCHLD for state start
systemd[1]: ip6tables.service changed start -> maintenance

I think a better term is needed, perhaps "failing".  And perhaps it could use the exit status and for example report "not configured" in the above case.

Comment 3 Lennart Poettering 2010-07-18 01:49:36 UTC
The term is actually taken from Solaris SMF where a similar state exists for services. We thought it would be a good idea to reuse the same terminology used in other systems as far as that makes sense.

I have now documented the state in the man pages in git upstream.

Comment 4 Matthew Miller 2010-08-25 15:43:46 UTC
Please reconsider using "failing" or "broken" instead. This will save a lot of support requests later. "Refer to the docs" is one answer, but "it's obvious" is better.

The system isn't in widespread use and this is already the second confused person I've seen. Third, if you count me.

Comment 5 Orion Poplawski 2010-08-25 22:06:25 UTC
I like "failing" or "failed" - this is a typical "bad" word one looks for in logs.

Comment 6 Lennart Poettering 2010-08-26 16:13:16 UTC
Well, "failing" is not the right word, because it already failed. 

Note that I think "broken" and "failed" are too strong words. A non-zero code does not necessarily mean that something is really broken, just that it needs somebody to look into.

Also, again, this is a name we jacked from Solaris, and I am not sure we should innovate in this area.

I am open to change this, but I don't think that "broken" or "failed" are better choices than "maintenance".

Comment 7 Lennart Poettering 2010-08-26 16:17:47 UTC
(In reply to comment #6)
> Note that I think "broken" and "failed" are too strong words. A non-zero code

"non-zero exit code" that is.

Comment 8 Matthew Miller 2010-08-26 16:21:16 UTC
"Failed" is probably better than "broken", because it's less strong. And it sounds a little more business-y than "broken", making it a nice middle ground between the _very_ jargon-y term "maintenance".

Comment 9 Bill Nottingham 2010-08-26 16:34:52 UTC
Furthermore, 'failed' is pretty standard parlance for things that return non-zero exit codes. It's what the old sysv wrapper printed in that case, etc.

Comment 10 Rahul Sundaram 2010-08-26 18:07:35 UTC
Yep.  I agree with "failed" as well.

Comment 11 Matthew Miller 2010-08-26 20:07:52 UTC
Created attachment 441325 [details]
changes "maintenance" to "failed" throughout

Patch against current git. Changes maintenance to failed everywhere, except where the word is used to mean actual maintenance, which it is a couple of times in the documentation. Applies and compiles cleanly. Will test soon. :)

Comment 12 Matthew Miller 2010-08-26 20:08:34 UTC
Comment on attachment 441325 [details]
changes "maintenance" to "failed" throughout

Wait, attached older file. Hold on.

Comment 13 Matthew Miller 2010-08-26 20:13:17 UTC
UNIT_FAILED is already used in the code. So my naive change doesn't work. Please hold. :)

Comment 14 Matthew Miller 2010-08-26 20:38:58 UTC
Created attachment 441327 [details]
patch to change 'maintenance' to 'failed'

This patch changes the old UNIT_FAILED to UNIT_ERROR, so there is no conflict.

And now everything works great. Slight bit of testing, even.

Comment 15 Lennart Poettering 2010-08-27 12:06:49 UTC
ok, will merge this patch.

Comment 16 Matthew Miller 2010-08-27 12:21:52 UTC
Thanks man. :)

Comment 17 Lennart Poettering 2010-08-30 22:18:44 UTC
Fixed now upstream.

Comment 18 Fedora Update System 2010-09-03 03:38:04 UTC
systemd-9-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/systemd-9-2.fc14

Comment 19 Fedora Update System 2010-09-03 16:44:05 UTC
systemd-9-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update systemd'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/systemd-9-2.fc14

Comment 20 Fedora Update System 2010-09-03 22:36:56 UTC
systemd-9-3.fc14, initscripts-9.18-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update systemd initscripts'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/systemd-9-3.fc14,initscripts-9.18-1.fc14

Comment 21 Fedora Update System 2010-09-08 03:18:17 UTC
initscripts-9.19-1.fc14, systemd-9-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update initscripts systemd'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/systemd-9-3.fc14,initscripts-9.19-1.fc14

Comment 22 Fedora Update System 2010-09-10 15:14:05 UTC
initscripts-9.20-1.fc14, sysvinit-2.87-5.dsf.fc14, systemd-9-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update initscripts sysvinit systemd'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/systemd-9-3.fc14,initscripts-9.20-1.fc14,sysvinit-2.87-5.dsf.fc14

Comment 23 Fedora Update System 2010-09-14 04:28:29 UTC
systemd-10-1.fc14, initscripts-9.20-1.fc14, sysvinit-2.87-5.dsf.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update systemd initscripts sysvinit'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/systemd-10-1.fc14,initscripts-9.20-1.fc14,sysvinit-2.87-5.dsf.fc14

Comment 24 Fedora Update System 2010-09-15 07:12:05 UTC
initscripts-9.20-1.fc14, sysvinit-2.87-5.dsf.fc14, systemd-10-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.