Bug 614688 - support searching values with single-quotes across the system
Summary: support searching values with single-quotes across the system
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: SearchBar
Version: 3.0.0
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
: ---
Assignee: Joseph Marques
QA Contact: John Sanda
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-15 01:06 UTC by Joseph Marques
Modified: 2010-08-12 16:59 UTC (History)
0 users

Fixed In Version: 2.4
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-08-12 16:59:55 UTC
Embargoed:

Attachments (Terms of Use)

Description Joseph Marques 2010-07-15 01:06:54 UTC 
Searching for single-quotes is broken across the entire system.  If you try to use the SLSB interfaces, or the Criteria API, or the SearchBar - it doesn't work anywhere.  When formatting query parameters that represent searchable fields, we need to escape single-quotes.  Luckily, this functionality is centralized in QueryUtility class today, so updating it once there should enable this functionality for all places that call into it.
Comment 1 Joseph Marques 2010-07-15 01:14:56 UTC 
commit 8d0b63fa40dfd3f0dacd82b1e7003094fe8216e7
Author: Joseph Marques <joseph>
Date:   Wed Jul 14 21:07:11 2010 -0400

    BZ-614688: support searching for values that contain single-quotes
Comment 2 John Sanda 2010-07-19 14:22:53 UTC 
Testing with build 175 of ci-rhq-release job.

Searches for the following strings worked as expected,

John's Job
'my broken job'
my 'broken' job
my 'broken' 'job'
my '"' broken job


Joseph pointed out to me that only a single level of nesting is supported; so, the following is not considered legal,

my '"'broken'"' job

since it nests single quotes two levels deep.
Comment 3 Corey Welton 2010-08-12 16:59:55 UTC 
Mass-closure of verified bugs against JON.
Note You need to log in before you can comment on or make changes to this bug.