Spec URL: http://rpms.damian.net/SPECS/php-phpunit-PHP-Timer.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpunit-PHP-Timer-1.0.0-1.fc13.src.rpm Description: PHP Utility class for timing
(unofficial) rpmlint php-phpunit-PHP-Timer-1.0.0-1.fc13.noarch.rpm php-phpunit-PHP-Timer.noarch: I: enchant-dictionary-not-found en_US php-phpunit-PHP-Timer.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. http://fedoraproject.org/wiki/Packaging:ReviewGuidelines
=== FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the PHP specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: F-14 x86_64 [x] Rpmlint output: php-phpunit-PHP-Timer.spec: I: checking-url http://pear.phpunit.de/get/PHP_Timer-1.0.0.tgz (timeout 10 seconds) php-phpunit-PHP-Timer.src: I: checking php-phpunit-PHP-Timer.src: I: checking-url http://github.com/sebastianbergmann/php-timer/ (timeout 10 seconds) php-phpunit-PHP-Timer.src: I: checking-url http://pear.phpunit.de/get/PHP_Timer-1.0.0.tgz (timeout 10 seconds) php-phpunit-PHP-Timer.noarch: I: checking php-phpunit-PHP-Timer.noarch: I: checking-url http://github.com/sebastianbergmann/php-timer/ (timeout 10 seconds) php-phpunit-PHP-Timer.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. [x] Package is not relocatable. [x] Buildroot is correct Used : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: BSD [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : aee6ce1de0a75bd0b914c7344a97113e PHP_Timer-1.0.0.tgz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Final requires /bin/sh /usr/bin/pear php-channel(pear.phpunit.de) php-common >= 5.2.7 [ ] Final provides php-pear(pear.phpunit.de/PHP_Timer) = 1.0.0 php-phpunit-PHP-Timer = 1.0.0-1.fc14 === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: koji build --scratch dist-rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=2489675 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: [x] Package functions as described. [x] Scriptlets must be sane, if used. class is register on yum install class is unregister on yum remove [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the tests pass Perhaps you could fix the many awful date warning during build... ;) **** APPROVED ****
(In reply to comment #2) > > Perhaps you could fix the many awful date warning during build... ;) will do :-) that is one of the most annoying warnings of PHP, some sensible default would be nice. > > **** APPROVED **** Cheers New Package SCM Request ======================= Package Name: php-phpunit-PHP-Timer Short Description: PHP Utility class for timing Owners: cdamian Branches: f14 el6 InitialCC:
Git done (by process-git-requests).
php-phpunit-PHP-Timer-1.0.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/php-phpunit-PHP-Timer-1.0.0-2.fc14
php-phpunit-PHP-Timer-1.0.0-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-phpunit-PHP-Timer'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-phpunit-PHP-Timer-1.0.0-2.fc14
php-phpunit-PHP-Timer-1.0.0-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.