Spec URL: http://pwu.fedorapeople.org/cjkuni-uming-fonts/cjkuni-uming-fonts.spec
SRPM URL: http://pwu.fedorapeople.org/cjkuni-uming-fonts/cjkuni-uming-fonts-0.2.20080216.1-43.fc13.src.rpm
CJK Unifonts are Unicode TrueType fonts derived from original fonts made available by Arphic Technology under "Arphic Public License" and extended by the CJK Unifonts project.
I see current cjkuni-fonts package in fedora also installs -ghostscript. Is there any reason to drop it?
Sorry, open review request for cjkuni-fonts-ghostscript lately.
For -ghostscript sub-package, see:
Bug 615192 - Review Request: cjkuni-fonts-ghostscript -Chinese Unicode TrueType font ghostscript files
New rpm spec for reviewing:
few more fixes this package needs
1) you don't need obsoletes for cjkunifonts-uming , we should keep them for 2 releases and as I see last rename happened around F11 development cycle.
2) build.log showed
warning: File listed twice: /etc/fonts/conf.d/65-0-ttf-arphic-uming.conf
warning: File listed twice: /usr/share/fontconfig/conf.avail/65-0-ttf-arphic-uming.conf
This happened as those entries are written manually which are actually part of %_font_pkg macro
3) Drop INSTALL file which is not needed as we install this package using yum.
Drop zero-length file TODO
4) I see there are 3 fontconfig files but only one is installed.
4) oops my eyes missed that you used wildcard character "*" . So all 3 fontconfigs are getting installed.
so here is the fix. Use following
%_font_pkg -f *.conf *.ttc
and remove following 2 lines
The above changes has been merged into new cjkuni-uming-fonts.spec.
New rpm spec for reviewing:
+ package builds in mock (rawhide i686).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2330459
+ rpmlint output for SRPM and for RPM.
cjkuni-uming-fonts.src: W: no-cleaning-of-buildroot %install
cjkuni-uming-fonts.src: W: no-cleaning-of-buildroot %clean
cjkuni-uming-fonts.src: W: no-buildroot-tag
cjkuni-uming-fonts.src: W: no-%clean-section
cjkuni-uming-fonts.noarch: W: obsolete-not-provided cjkuni-fonts-common
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
==> Ok for this package
+ source files match upstream url (sha1sum)
+ package meets naming guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ package installed properly.
+ Macro use appears rather consistent.
+ no .pc file present.
+ no -devel subpackage
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ follows fonts packaging guidelines.
New Package CVS Request
Package Name: cjkuni-uming-fonts
Short Description: Chinese Unicode TrueType font in Ming face
Branches: F-13 F-14
InitialCC: petersen i18n-team
CVS done (by process-cvs-requests.py).
cjkuni-uming-fonts-0.2.20080216.1-45.fc14 has been submitted as an update for Fedora 14.
cjkuni-uming-fonts-0.2.20080216.1-45.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update cjkuni-uming-fonts'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/cjkuni-uming-fonts-0.2.20080216.1-45.fc14
cjkuni-uming-fonts-0.2.20080216.1-45.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.