Red Hat Bugzilla – Bug 615163
Review Request: perl-MooseX-Types-Structured - Structured Type Constraints for Moose
Last modified: 2010-07-17 02:20:36 EDT
Spec URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-Types-Structured.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-Types-Structured-0.23-1.fc14.src.rpm Description: A structured type constraint is a standard container Moose type constraint, such as an ArrayRef or HashRef, which has been enhanced to allow you to explicitly name all the allowed type constraints inside the structure. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2323330 *rt-0.10_01
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 79a2929872d4c2b0716a998042289b846bcde44f MooseX-Types-Structured-0.23.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel [x] Package should compile and build into binary rpms on all supported architectures. Tested on: noarch, perl module [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [!] %check is present and the test passes. Note 1: ================ *** APPROVED *** ================
I think following BR: is not needed please remove it BuildRequires: perl >= 0:5.008 Also, Requires should not be needed as they should get automatically pulled by rpm.
New Package CVS Request ======================= Package Name: perl-MooseX-Types-Structured Short Description: Structured Type Constraints for Moose Owners: iarnell Branches: F-12 F-13 InitialCC: perl-sig
(In reply to comment #2) > I think following BR: is not needed please remove it > BuildRequires: perl >= 0:5.008 Ack. I should really patch that out of my cpanspec. > Also, Requires should not be needed as they should get automatically pulled by > rpm. perl(Devel::PartialDump) >= 0.13 can probably go as that's the only version we have so far. perl(Moose) >= 1.08 seems to be a hard requirement only available in rawhide (at the minute). perl(Moose::Meta::*) are currently part of Moose itself so could be dropped.
CVS done (by process-cvs-requests.py).
Imported with cleaned up spec (to rawhide only at the minute). Thanks for the review.