Spec URL: http://red-dragon.com/perl-Crypt-Cracklib.spec SRPM URL: http://red-dragon.com/perl-Crypt-Cracklib-1.4-1.fc13.src.rpm Description: This is a perl module to interact with system libcrack
This is my first package and requesting sponsor per http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Guidelines
Updated Spec after run of rpmlint to fix warnings. New spec is uploaded to url listed.
Updated spec so that spec and package pass rpmlint with no warnings or errors.
Submitted both patches in package upstream to author: https://rt.cpan.org/Public/Bug/Display.html?id=59488 https://rt.cpan.org/Public/Bug/Display.html?id=59489
Updated to Crypt-Cracklib 1.5 Spec URL: http://red-dragon.com/perl-Crypt-Cracklib.spec SRPM URL: http://red-dragon.com/perl-Crypt-Cracklib-1.5.1.fc13.src.rpm Both upstream patches were applied by author is reason for 1.5 release passed rpmlint no errors koji builds on F13 and rawhide passed
reviewed https://bugzilla.redhat.com/show_bug.cgi?id=615577
Another package I've submitted is https://bugzilla.redhat.com/show_bug.cgi?id=617400
I'll go ahead and review this and your other submission and look at sponsoring you. ;) Look for a full review in a while here...
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL+ or artistic) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: e5fe8cd8894b2d66767e48f51779d778 Crypt-Cracklib-1.5.tar.gz e5fe8cd8894b2d66767e48f51779d778 Crypt-Cracklib-1.5.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. See below - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. See below - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. See below - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. See below - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. You are disabling the internal dependency generator here, but not doing any manual dependency generation. Why? I see no problems removing that line here. 2. The: if [ ! "$RPM_BUILD_ROOT" = "/" ] then in install and clean sections should be removed. There are no longer required or wanted. ;) 3. There seems to be a test suite here. Perhaps run it in %check? See https://fedoraproject.org/wiki/Packaging/Perl#Testing_and_Test_Suites 4. You should include Changes and README as %doc files. Also, you may want to ask upstream to include a copy of the license. 5. You need to own the %{perl_archlib}/Crypt/ directory here. Either change %{perl_archlib}/Crypt/Cracklib.pm to just %{perl_archlib}/Crypt/ or add a %dir%{perl_archlib}/Crypt to files. Likewise for the auto/Crypt dir. 6. rpmlint says: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. 7. Did you take an existing spec to create this one? If so, please do leave the old spec changelog entries to credit the orig author(s).
New spec and build tested on koji dist-f13 and dist-rawhide
Please do add a changelog entry and bump Release while making changes for the review. This prevents confusion between submitter and reviewer as to what they are looking at. ;) Can you add pointers to the current spec/src.rpm?
SPEC: http://red-dragon.com/perl-Crypt-Cracklib.spec SRPM: http://red-dragon.com/perl-Crypt-Cracklib-1.5-2.fc13.src.rpm 1) re enabled the internal dependancy generator 2) removed the $RPM_BUILD_ROOT test from install and clean 3) added %check section with make test 4) included the Changes and README as %doc files 5) Many perl packages sit in Crypt so can't properly own to this package 6) rpmlint says [redragon@gkar SPECS]$ rpmlint perl-Crypt-Cracklib.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [redragon@gkar x86_64]$ rpmlint perl-Crypt-Cracklib-1.5-2.fc13.x86_64.rpm perl-Crypt-Cracklib.x86_64: W: private-shared-object-provides /usr/lib64/perl5/auto/Crypt/Cracklib/Cracklib.so Cracklib.so()(64bit) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. 7) this is a new spec just for this package koji build on rawhide passed no failures koji build on f13 passed no failures
1, 2, 3, all look good. on 4: You can replace: %doc %{_defaultdocdir}/perl-Crypt-Cracklib-%{version}/Changes %doc %{_defaultdocdir}/perl-Crypt-Cracklib-%{version}/README with just: %doc Changes README 5. I think this falls under: https://fedoraproject.org/wiki/Packaging/Guidelines#Multiple_packages_own_files_in_a_common_directory_but_none_of_them_needs_to_require_the_others. I see currently all of the following own this dir: perl-Crypt-OpenSSL-PKCS10-0:0.06-15.fc14.x86_64 perl-Crypt-OpenSSL-Random-0:0.04-12.fc14.x86_64 perl-Crypt-DES-0:2.05-11.fc14.x86_64 perl-Crypt-OpenSSL-X509-0:0.7-7.fc14.x86_64 perl-Crypt-Eksblowfish-0:0.008-2.fc14.x86_64 perl-Crypt-Twofish-0:2.14-2.fc14.x86_64 perl-Crypt-OpenSSL-RSA-0:0.25-12.fc14.x86_64 perl-Crypt-SSLeay-0:0.57-17.fc14.x86_64 perl-Crypt-OpenSSL-AES-0:0.02-11.fc14.x86_64 perl-Crypt-Rijndael-0:1.09-2.fc14.x86_64 perl-Crypt-Blowfish-0:2.10-10.fc14.x86_64 crypto-utils-0:2.4.1-27.x86_64 perl-Crypt-OpenSSL-Bignum-0:0.04-10.fc14.x86_64 perl-Crypt-OpenSSL-DSA-0:0.13-16.fc14.x86_64 perl-Crypt-SMIME-0:0.09-4.fc14.x86_64 6 and 7: ok. I see you have a Epoch: 1 here. Why?
SPEC: http://red-dragon.com/perl-Crypt-Cracklib.spec SRPM: http://red-dragon.com/perl-Crypt-Cracklib-1.5-3.fc13.src.rpm 4) updated %doc in files section 5) added the Crypt directory (amazingly this corrected the .so error) Epoch was removed, no idea why I plugged that one in.
4. Looks good. 5. Looks good. I don't see any further blockers here, so this package is APPROVED. Let me know your fedora account system login and I will sponsor you. Please feel free to ping me on irc, email or this bug and I will be happy to help answer any questions you have.
New Package CVS Request ======================= Package Name: perl-Crypt-Cracklib Short Description: perl module to interact with libcrack Owners: redragon Branches: F-13 InitialCC: redragon
GIT done (by process-cvs-requests.py). With f14 branch added.
perl-Crypt-Cracklib-1.5-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc13
perl-Crypt-Cracklib-1.5-3.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc14
perl-Crypt-Cracklib-1.5-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Crypt-Cracklib'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc14
perl-Crypt-Cracklib-1.5-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Crypt-Cracklib'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc13
perl-Crypt-Cracklib-1.5-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
perl-Crypt-Cracklib-1.5-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-Crypt-Cracklib New Branches: EPEL5 EPEL6 Owners: redragon InitialCC: redragon
Git done (by process-git-requests).
perl-Crypt-Cracklib-1.7-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.7-1.fc13
perl-Crypt-Cracklib-1.7-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.7-1.fc14
Hi, I requested an EPEL-7 branch for this package as it's an optional dependency of the proftpd test suite. I don't know if you're interested in EPEL at all, so I'm happy to maintain the EPEL-7 branch myself if you're not interested. I'm also happy to co-maintain the package if you like. Cheers, Paul.
perl-Crypt-Cracklib-1.7-19.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-56b4c757c7
perl-Crypt-Cracklib-1.7-19.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-56b4c757c7
perl-Crypt-Cracklib-1.7-19.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.