Bug 615809 - Review Request: geronimo-annotation - Java EE: Annotation API v1.1
Summary: Review Request: geronimo-annotation - Java EE: Annotation API v1.1
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 616250
TreeView+ depends on / blocked
Reported: 2010-07-18 23:37 UTC by Spike
Modified: 2010-07-27 04:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-07-27 04:57:30 UTC
Type: ---
sochotni: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Comment 1 Stanislav Ochotnicky 2010-07-20 09:05:30 UTC
I can do the review

Comment 2 Stanislav Ochotnicky 2010-07-20 12:21:49 UTC
Before I start official review....The package name should not include version of the specification. I know we talked about this before...but if you look at other geronimo-XXX packages present in fedora (for example geronimo-jms) you can see they don't use spec version in names. 

In case we will ever need to have two different specs present we can "fix" naming later, but it's better to be consistent (reminds me of http://www.despair.com/consistency.html)...

With this naming change there is also Provides that is not so great IMO:

> Provides:         annotation_1_0_api = %{version}-%{release}

That provides can be skipped entirely, you already have annotation_api Provides.

Otherwise package seems pretty good to me.

Comment 3 Spike 2010-07-25 06:46:22 UTC
Changed package name to "geronimo-annotation" and updated to version 1.1. New spec and SRPM:


Comment 4 Stanislav Ochotnicky 2010-07-26 08:18:33 UTC
NEEDSWORK: rpmlint must be run on every package. The output should be posted in the review.

geronimo-annotation.noarch: W: non-conffile-in-etc /etc/maven/fragments/geronimo-annotation
geronimo-annotation.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/geronimo-annotation-1.0/LICENSE
geronimo-annotation.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 20)
geronimo-annotation-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/geronimo-annotation-javadoc-1.0/LICENSE
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

The non-conffile-in-etc can be fixed with:
%config(noreplace) %{_mavendepmapfragdir}/*

EOLs...simple sed and white space...that's probably manual work :-)

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.  .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. 
OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
OK: All independent sub-packages have License of their own (if it exists)
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. 
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). 
OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. 
OK: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. 
OK: All filenames in rpm packages must be valid UTF-8.


 * %description of main package could be more descriptive (implementation
   of JSR-XXX, etc etc)

Other than those rpmlint warnings and description there were no
problems. Please fix those whitespace warnings and I will be able to
approve this package.

Comment 5 Spike 2010-07-26 08:55:25 UTC
(In reply to comment #4)
> NEEDSWORK: rpmlint must be run on every package.

Done. New spec and SRPM:


Comment 6 Stanislav Ochotnicky 2010-07-26 10:05:28 UTC
Everything is in order now, package is APPROVED.

Comment 7 Spike 2010-07-26 10:51:25 UTC
New Package CVS Request
Package Name: geronimo-annotation
Short Description: Java EE: Annotation API v1.1
Owners: spike

Comment 8 Kevin Fenzi 2010-07-26 22:33:13 UTC
CVS done (by process-cvs-requests.py).

Comment 9 Spike 2010-07-27 04:57:30 UTC
Package built, closing.

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2353374

Note You need to log in before you can comment on or make changes to this bug.