Bug 617618 - Review Request: perl-Carp-Always - Warn and die in Perl noisily with stack backtraces
Review Request: perl-Carp-Always - Warn and die in Perl noisily with stack ba...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
13
All Linux
low Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-23 10:51 EDT by Lubomir Rintel
Modified: 2010-07-24 09:29 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-07-24 09:29:36 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Lubomir Rintel 2010-07-23 10:51:10 EDT
SPEC: http://v3.sk/~lkundrak/SPECS/perl-Carp-Always.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Carp-Always-0.09-1.fc13.src.rpm

Description:

This module is meant as a debugging aid. It can be used to make a script
complain loudly with stack backtraces when warn()ing or die()ing.
Comment 1 Maros Zatko 2010-07-23 14:35:48 EDT
MUST items
==========

MUST: rpmlint must be run on every package. The output should be posted in the
review.[1] 

perl-Carp-Always.src: W: spelling-error Summary(en_US) backtraces ->
backtracks, back traces, back-traces
perl-Carp-Always.src: W: spelling-error %description -l en_US backtraces ->
backtracks, back traces, back-traces
perl-Carp-Always.src: W: spelling-error %description -l en_US ing -> ING, ign,
inf
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


MUST: The package must be named according to the Package Naming Guidelines .
OK

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] . 
OK

MUST: The package must meet the Packaging Guidelines .
? (but I assume it's OK)

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK

MUST: The License field in the package spec file must match the actual license.
[3]
OK

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK


MUST: The spec file must be written in American English. [5]
OK

MUST: The spec file for the package MUST be legible. [6]
OK (appears to be OK)

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
OK

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
OK

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
OK

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
OK

MUST: Packages must NOT bundle copies of system libraries.[11]
OK

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
OK

MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13]
OK

MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
OK

MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]
OK

MUST: Each package must consistently use macros. [16]
OK

MUST: The package must contain code, or permissable content. [17]
OK

MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
OK

MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
OK

MUST: Header files must be in a -devel package. [19]
OK

MUST: Static libraries must be in a -static package. [20]
OK

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. [19]
OK

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} [21]
OK

MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.[20]
OK

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[22]
OK

MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. [23]
OK

MUST: All filenames in rpm packages must be valid UTF-8. [24]
OK

SHOULD items
============


SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it. [25]

I don't know much about this, but there is LICENCE mentioned in README, so I
assume it's OK.


SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available. [26]

??


SHOULD: The reviewer should test that the package builds in mock. [27]
OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=2346919


SHOULD: The package should compile and build into binary rpms on all supported
architectures. [28]
OK


SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
OK


SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
and left up to the reviewers judgement to determine sanity. [29]
OK (I think it is)

SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency. [21]
OK


SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb. [30]
OK, does not contain any


SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. [31]
OK


SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.[32]
OK
Comment 2 Maros Zatko 2010-07-23 14:41:00 EDT
This was an informal review, it is still waiting for a formal one.
Comment 3 manuel wolfshant 2010-07-23 15:11:07 EDT
Maros, thank you for the informal review. PLease keep in mind that verifying the source rpm via rpmlint is not enough, as files might get created/ modified during the build process. See the issue on the README file below

Official review:


Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM:
arp-Always.src: W: spelling-error Summary(en_US) backtraces -> backtracks, back traces, back-traces
perl-Carp-Always.src: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces
perl-Carp-Always.src: W: spelling-error %description -l en_US ing -> ING, inf, in
binary RPM:
perl-Carp-Always.noarch: W: spelling-error Summary(en_US) backtraces -> backtracks, back traces, back-traces
perl-Carp-Always.noarch: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces
perl-Carp-Always.noarch: W: spelling-error %description -l en_US ing -> ING, inf, in
perl-Carp-Always.noarch: W: file-not-utf8 /usr/share/doc/perl-Carp-Always-0.09/README
=> Lubomir, please convert the file and shutup rpmlint

 [x] Package is not relocatable.
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: same as Perl (Artistic or GPL+)
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package match the upstream source, as provided in the spec URL.
     SHA1SUM of source file: 2e10b9bb6593f4e1c078911ccc1142c2598ea321  /tmp/Carp-Always-0.09.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
 [x] Package does not own files or directories owned by other packages.
 [x] Final provides and requires are sane.
Requires:
perl >= 0:5.006
perl(:MODULE_COMPAT_5.12.1)
perl(Carp)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rpmlib(PayloadIsXz) <= 5.2-1

Provides:
perl(Carp::Always) = 0.09
perl-Carp-Always = 0.09-1.fc14

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [ ] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build/rawhide
 [x] Package should compile and build into binary rpms on all supported architectures.
     Tested on: koji scratch build/rawhide
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the test passes.

=== OPTIONAL ITEMS ===
 [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.

=== Issues ===
1. Please convert the generated README file to UTF-8.

================
*** APPROVED ***
================
Comment 4 Lubomir Rintel 2010-07-23 15:24:30 EDT
Thank you Ma{ros,nuel}

README fixed:

SPEC: http://v3.sk/~lkundrak/SPECS/perl-Carp-Always.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Carp-Always-0.09-2.fc13.src.rpm

New Package CVS Request
=======================
Package Name: perl-Carp-Always
Short Description: Warn and die in Perl noisily with stack backtraces
Owners: lkundrak
Branches: F-12 F-13 EL-5 EL-6
Comment 5 Kevin Fenzi 2010-07-23 17:47:28 EDT
CVS done (by process-cvs-requests.py).
Comment 6 Lubomir Rintel 2010-07-24 09:29:36 EDT
Imported and built.

Thank you!

Note You need to log in before you can comment on or make changes to this bug.