Bug 617803 - Update Request: rubygem-actionpack - additional rack-1.1.0 compat fix
Summary: Update Request: rubygem-actionpack - additional rack-1.1.0 compat fix
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-actionpack
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Mo Morsi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-24 04:20 UTC by Mo Morsi
Modified: 2010-09-17 18:20 UTC (History)
5 users (show)

Fixed In Version: rubygem-actionpack-2.3.5-3.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-17 18:20:11 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mo Morsi 2010-07-24 04:20:50 UTC
Description of problem:
Since rack-1.1.0 stores headers in an array and not a string, rubygem-actionpack requires the following patch:

http://cvs.fedoraproject.org/viewvc/rpms/rubygem-actionpack/F-13/rubygem-actionpack-2.3.5-rack-compat.patch?view=markup

Attached is an updated patch with one addition, removing a newline from being prepended when multiple headers are present. 

This newline made sense in the context of the headers string as it acted as a delimiter. 

But in the context of the headers array it does not, and infact it causes breakage in actionpack/action_controller/integration.rb line 334 which will throw the following exception if the first character in the header string is a newline (as it is if there are multiple headers)

You have a nil object when you didn't expect it!
You might have expected an instance of ActiveRecord::Base.
The error occurred while evaluating nil.[] (NoMethodError)

The patch with the removal of the newline can be found here

http://mo.morsi.org/files/patches/rubygem-actionpack-2.3.5-rack-compat.patch

Version-Release number of selected component (if applicable):
rubygem-actionpatch-2.3.5

How reproducible:
Occurs when running the deltacloud feature suite against rubygems installed via yum.

Steps to Reproduce:
1. Check out deltacloud as described here http://deltacloud.org/contribute.html
2. cd aggregator/src
3. rake feature
  
Actual results:
Exceptions thrown concerning nil class

Expected results:
Feature suite successfully executes (as it does when my patch is applied against actionpack 2.3.5)

Comment 1 Fedora Admin XMLRPC Client 2010-08-17 23:05:36 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Fedora Update System 2010-09-16 03:01:19 UTC
rubygem-actionpack-2.3.5-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-actionpack-2.3.5-3.fc13

Comment 3 Fedora Update System 2010-09-17 18:20:06 UTC
rubygem-actionpack-2.3.5-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.