Bug 618104 - /Ddefine= does not work, unlike native version.
Summary: /Ddefine= does not work, unlike native version.
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: mingw32-nsis
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-26 06:44 UTC by Hin-Tak Leung
Modified: 2010-07-26 09:51 UTC (History)
3 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2010-07-26 07:12:42 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Hin-Tak Leung 2010-07-26 06:44:41 UTC 
Description of problem:

Native makensis supports defines via /Ddefine=value and -Ddefine=value, whereas the mingw32-nsis only does -Ddefine=value . /Ddefine=value 
result in error messages like 

Can't open script "/DVERSION=9.00"

Version-Release number of selected component (if applicable):
mingw32-nsis-2.45-3.fc13.x86_64

How reproducible:
always

Steps to Reproduce:
1. Just try one of the examples with /Dsomething= vs -Dsomething=
2.
3.
  
Actual results:


Expected results:


Additional info:
Both dashes and slashes are supposed to be suported since 2.25 in upstream.
Comment 1 Kevin Kofler 2010-07-26 07:12:42 UTC 
Slashes as option characters only make sense on platforms which don't use it as path separators. As such, upstream only supports them for native builds. Dashes are supported everywhere.
Comment 2 Richard W.M. Jones 2010-07-26 09:46:34 UTC 
I think is at best only a marginal bug.

In any case, it's something that the reporter should pursue with
the upstream NSIS project.  We don't change the option handling
ability of NSIS in any way compared to upstream, AFAIK.
Comment 3 Kevin Kofler 2010-07-26 09:51:02 UTC 
Indeed we don't. This is exactly how things work upstream.
Note You need to log in before you can comment on or make changes to this bug.