Bug 618114 - Kernel panic on reading from /proc/bus/pci/XX/YY while hot-removing the device.
Summary: Kernel panic on reading from /proc/bus/pci/XX/YY while hot-removing the device.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
urgent
high
Target Milestone: rc
: ---
Assignee: Wade Mealing
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
: 648378 (view as bug list)
Depends On:
Blocks: 670075 675781 736725
TreeView+ depends on / blocked
 
Reported: 2010-07-26 07:18 UTC by Wade Mealing
Modified: 2018-11-26 19:43 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
When reading a file from a subdirectory in /proc/bus/pci/ while hot-unplugging the device related to that file, the system will crash. Now, the kernel correctly handles the simultaneous removal of a device and access to the representation of that device in the proc file system.
Clone Of:
: 670075 675781 (view as bug list)
Environment:
Last Closed: 2011-02-07 18:16:43 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0017 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.6 kernel security and bug fix update 2011-01-13 10:37:42 UTC

Description Wade Mealing 2010-07-26 07:18:03 UTC
Description of problem:

When we read from a /proc/bus/pci/XX/YY file while hot-removing the device that relates to this file, kernel panics with the following call trace.

Version-Release number of selected component (if applicable):

kernel-2.6.18-208.el5 and earlier.

How reproducible:

Every time.


Steps to Reproduce:
1. Open /proc/bus/pci/XX/YY file
2. remove a pci device with pci hotplug capabilities.
3. Read from the proc file.
  
Actual results:

Kernel panic

Expected results:

Device to be released, pci bus to continue working.

Additional info:

Accepted in linux-next branch, not in mainline yet.
https://patchwork.kernel.org/patch/107556/

Comment 4 RHEL Program Management 2010-08-03 13:09:17 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 5 Jan Tluka 2010-08-03 13:56:11 UTC
Wade, could you please include panic call trace? It's missing in the description.

Thanks.

Comment 8 Jarod Wilson 2010-08-11 00:13:27 UTC
in kernel-2.6.18-211.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 18 Wade Mealing 2010-11-02 04:56:40 UTC
*** Bug 648378 has been marked as a duplicate of this bug. ***

Comment 19 Wade Mealing 2010-11-02 04:59:24 UTC
As M Yamazaki stated, this wasn't enough to solve the problem (it did solve my simulated pci hotplug bug) but it requires additional protection from the upstream patch, I'm going to attach the patch, but awaiting feedback from our partners on if its sane and working for them.

Comment 20 Wade Mealing 2010-11-02 06:16:35 UTC
Looks like there needs to be additional changes, this patch did fix my original problem but there is more..

Comment 27 errata-xmlrpc 2011-01-13 21:45:10 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html

Comment 31 Suzanne Logcher 2011-02-07 18:16:43 UTC
This bug was part of the RHEL 5.6 kernel advisory and is associated with a patch in 5.6.
It has been returned to CLOSED/ERRATA status against 5.6, and will be cloned for handling further issues in RHEL 5.7.
Please address additional concerns in that bug and not this one.

Comment 34 Tomas Capek 2011-09-13 12:36:18 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
When reading a file from a subdirectory in /proc/bus/pci/ while hot-unplugging the device related to that file, the system will crash. Now, the kernel correctly handles the simultaneous removal of a device and access to the representation of that device in the proc file system.


Note You need to log in before you can comment on or make changes to this bug.