Spec URL: http://mso.fedorapeople.org/packages/SPECS/laughlin-backgrounds.spec SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/laughlin-backgrounds-13.91.0-1.fc12.src.rpm Description: Package containing Laughlin desktop backgrounds. The main package serves as metapackage pulling in both gnome and kde stuff, the -gnome and -kde subpackages are self-explanatory, -single subpackage serves for containing single screen images shared by both gnome and kde. As the -single one is needed by all the rest, I've put license and credits there.
I'm taking this completely for free ;) I guess this must be finished before Aug 3rd then?
(In reply to comment #1) > I'm taking this completely for free ;) > Thanks ;) > I guess this must be finished before Aug 3rd then? It needs to be build by that date, so to have enough time for CVS import it would be even better if it were at least a day earlier. In short, the sooner the better.
This package looks like there aren't any problems anyway. You used "F13 Laughlin" in the changelog, but that's about the only thing I was able to find. I'll probably do the full review stuff tomorrow.
MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. OK MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. N/A SHOULD: The package builds in mock. - builds fine for fedora-13-i386, fedora-rawhide-i386 and fedora-12-i386 NOTE: You do not need the BuildRoot tag anymore, so you could just remove it next time you update the package. APPROVED
Thanks for the review :-) I'll make the fixes you noted after the initial import.
New Package CVS Request ======================= Package Name: laughlin-backgrounds Short Description: Laughlin desktop backgrounds Owners: mso Branches: F-14 InitialCC:
CVS done (by process-cvs-requests.py).
goddard-backgrounds-13.0.0-2.fc14,laughlin-backgrounds-13.91.0-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/goddard-backgrounds-13.0.0-2.fc14,laughlin-backgrounds-13.91.0-1.fc14
goddard-backgrounds-13.0.0-2.fc14, laughlin-backgrounds-13.91.0-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.