Bug 618859 - RFE: make whiteboards editable
Summary: RFE: make whiteboards editable
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.5
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-27 21:31 UTC by Marian Csontos
Modified: 2011-09-28 15:34 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-10-14 03:13:14 UTC
Embargoed:


Attachments (Terms of Use)
Patch: make job whiteboard editable (7.72 KB, patch)
2010-08-20 04:50 UTC, Dan Callaghan
no flags Details | Diff

Description Marian Csontos 2010-07-27 21:31:33 UTC
I know it is my fault, but when cloning recipes I am often forgetting to update recipe's whiteboard.
It's not very helpful comparing such jobs in matrix view without knowing what is a regression and what an improvement...

Comment 1 Dan Callaghan 2010-08-20 04:50:05 UTC
Created an attachment (id=439860)
Patch: make job whiteboard editable

Comment 2 Dan Callaghan 2010-08-20 04:53:04 UTC
The attached patch is my first go at implementing this. It seems to work nicely, although I'm not happy with how the UI looks (wasted too much time fiddling with it already though).

Might be possible to turn the new JobWhiteboard widget into some kind of generic "inline field with AJAXy submission" widget, if we have a need for it later.

I'll add a test case for editing the job whiteboard, as soon as I figure out how to do that.

Comment 3 Dan Callaghan 2010-09-27 03:06:51 UTC
Pushed branch bz618859 for review. I'd like to include this with 0.5.59. (I realise this is a low-priority RFE, but I've been sitting on a patch for this since my first week, and I figure it might as well get released.)

http://git.fedorahosted.org/git/?p=beaker.git;a=commitdiff;h=4c290f0c15988d1f9e1e90afcd62e0f73aefaaee


Note You need to log in before you can comment on or make changes to this bug.