Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-stomp.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-stomp-1.1.6-1.fc13.src.rpm Description: Ruby client for the Stomp messaging protocol
For 1.1.6-1 * Unneeded macros - %ruby_sitelib macro seems to be used nowhere. * License - is actually "ASL 2.0" * BuildRoot - is no longer needed for Fedora and EPEL6. https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Requires - "R: ruby(abi) = 1.8" is a must. https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines - ">= 0" part on "R: rubygem(rspec)" is redundant. * %files - %{geminstdir}/spec can be %doc - %{geminstdir}/stomp.gemspec is not needed. - Also would you consider to create -doc subpackage and move the following files to -doc? --------------------------------------------------------------- %{geminstdir}/spec %{geminstdir}/test %{geminstdir}/examples %{geminstdir}/Rakefile %{gemdir}/doc/%{gemname}-%{version} --------------------------------------------------------------- * %check - As this gem contains spec/ and test/ directory, please add %check section and execute some test program there (like $ rake spec or $ rake test )
- Removed unsed macro. - Fixed License - While the BR isn't needed in the newer specs, I plan on putting this in EPEL5. I'd rather just keep it in to have only once spec to maintain. Thoughts? - Fixed Requires, I seem to forget that often - Removed >0 on rpsec - Updated %files and broke into two packages - %Check runs spec. I can't run test because there isn't a stomp server and it requires tcp access. http://stahnma.fedorapeople.org/reviews/rubygem-stomp.spec http://stahnma.fedorapeople.org/reviews/rubygem-stomp-1.1.6-1.fc13.src.rpm
For -2: * BR style - Please unify to "BuildRequires: rubygem(rspec)" style. * BR - "BR: rubygem(rake)" is needed (otherwise rake spec cannot be executed) * %defattr - Please set %defattr on -doc subpackage. ! By the way I usually think that %doc attribute on -doc subpackage is redundant because its rpm name already indicates that this rpm is for documentation. * Documentation - License related files should be in main package. Please move the following files to main. ---------------------------------------------------------- %{geminstdir}/CHANGELOG.rdoc %{geminstdir}/LICENSE %{geminstdir}/README.rdoc ----------------------------------------------------------
http://stahnma.fedorapeople.org/reviews/rubygem-stomp.spec http://stahnma.fedorapeople.org/reviews/rubygem-stomp-1.1.6-3.fc14.src.rpm - Fixed the BR - BR Rake is now added. - Set a %defattr and removed %doc tag for files in -doc packge - Moved Main license files back to original package
For -3: * %geminstdir - Please change "%dir %{gemdir}/gems/%{gemname}-%{version}" in %files to "%dir %{geminstdir}". * Requires - rubygem(rspec) seems needed only for development purpose (Rakefile) and does not seem to be needed for runtime (in .gemspec file "rspec" file is marked as s.add_development_dependency) Please fix above when importing this into Fedora VCS. ------------------------------------------------------- This package (rubygem-stomp) is APPROVED by mtasaka -------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-stomp Short Description: Ruby client for the Stomp messaging protocol Owners: stahnma Branches: F-12 F-13 EL-5 EL-6 InitialCC:
Git done (by process-git-requests). Added f14 branch
rubygem-stomp-1.1.6-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/rubygem-stomp-1.1.6-1.fc14
rubygem-stomp-1.1.6-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-stomp-1.1.6-1.fc13
rubygem-stomp-1.1.6-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-stomp-1.1.6-1.el5
rubygem-stomp-1.1.6-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-stomp-1.1.6-1.fc12
rubygem-stomp-1.1.6-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-stomp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-stomp-1.1.6-1.el5
rubygem-stomp-1.1.6-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-stomp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-stomp-1.1.6-1.fc13
rubygem-stomp-1.1.6-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-stomp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-stomp-1.1.6-1.fc12
Closing.
rubygem-stomp-1.1.6-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-stomp-1.1.6-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-stomp-1.1.6-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-stomp-1.1.6-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.