Bug 620882 - Review Request: minitube - A YouTube desktop client
Summary: Review Request: minitube - A YouTube desktop client
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-03 17:04 UTC by Magnus Tuominen
Modified: 2010-08-04 09:44 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-08-04 09:09:01 UTC


Attachments (Terms of Use)

Description Magnus Tuominen 2010-08-03 17:04:24 UTC
Spec URL: http://magnu5.fedorapeople.org/review/minitube/SPECS/minitube.spec
SRPM URL: http://magnu5.fedorapeople.org/review/minitube/SRPMS/minitube-1.1-1.fc13.src.rpm

Description: Minitube is a YouTube desktop client.
With it you can watch YouTube videos in a new way:
you type a keyword, Minitube gives you an endless video stream.
Minitube is not about cloning the original YouTube web interface,
it aims to create a new TV-like experience.

rpmlint -iv minitube.spec 
minitube.spec: I: checking-url http://flavio.tordini.org/files/minitube/minitube-1.1.tar.gz (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

rpmlint -iv minitube-1.1-1.fc13.src.rpm 
minitube.src: I: checking
minitube.src: I: checking-url http://flavio.tordini.org/minitube (timeout 10 seconds)
minitube.src: I: checking-url http://flavio.tordini.org/files/minitube/minitube-1.1.tar.gz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Magnus Tuominen 2010-08-03 17:20:57 UTC
Note to the reviewer:
I am not sure if this goes in fedora or not, this package needs xine-lib-extras-freeworld from rpmfusion to be able to play videos, but compiles and runs without it, the only thing that is missing is the playback.

Comment 2 Bill Nottingham 2010-08-03 18:03:33 UTC
Does it work with WebM videos?

Comment 3 Magnus Tuominen 2010-08-04 04:45:38 UTC
Yes it does, provided you have the codecs installed. Minitube uses phonon-backend-xine for that.

Comment 4 Kevin Kofler 2010-08-04 05:30:11 UTC
The only way you can possibly get this to play anything without packages from RPM Fusion is by installing phonon-backend-gstreamer and manually switching the Phonon backend to GStreamer (the default is Xine). Then it could in principle play back WebM videos, but does Minitube support them? In particular, does it know to pick the WebM format over other available ones? I doubt it.

With the default phonon-backend-xine, you need xine-lib-extras-freeworld even to support WebM (if it even works at all, see bug 606082) because xine-lib does not have native support for WebM/libvpx, it can only be played through FFmpeg which is in RPM Fusion.

So I think this package will have to go to RPM Fusion.

Comment 5 Magnus Tuominen 2010-08-04 07:40:00 UTC
Ok, I suspected as much, thanks Kevin. I'll close this and move it to rpmfusion instead.

Comment 6 Chen Lei 2010-08-04 07:59:50 UTC
This package should not go into rpmfusion. Obvious, it support xine-backend-gstreamer

Comment 7 Kevin Kofler 2010-08-04 08:06:39 UTC
IMHO this should be in RPM Fusion with a hard Requires on xine-lib-extras-freeworld.

There's no such thing as xine-backend-gstreamer, you mean phonon-backend-gstreamer. But have you actually tested Minitube with no plugins from RPM Fusion installed? It's not obvious that this works at all. And in any case, Phonon-GStreamer is not the default Phonon backend.

Comment 8 Chen Lei 2010-08-04 08:15:32 UTC
(In reply to comment #7)
> IMHO this should be in RPM Fusion with a hard Requires on
> xine-lib-extras-freeworld.
> 
> There's no such thing as xine-backend-gstreamer, you mean
> phonon-backend-gstreamer. But have you actually tested Minitube with no plugins
> from RPM Fusion installed? It's not obvious that this works at all. And in any
> case, Phonon-GStreamer is not the default Phonon backend.    

It works, my computer don't install xine-lib-freeworld at all. gnash is also use gstreamer to play flash videos, I don't think phonon-backend-gstreamer should depend on packages on rpmfusion.

Comment 9 Chen Lei 2010-08-04 08:25:23 UTC
Reopened.

Upstream also recommend to use gstreamer backend. Upstream also suggest remove xine backend, it seems the latest version is a bit incompatible with xine backend.

See http://flavio.tordini.org/minitube/minitube-linux-setup

Comment 10 Kevin Kofler 2010-08-04 08:27:46 UTC
If you have Gnash successfully playing videos, you have several codec packages from RPM Fusion.

The only format used by YouTube which can be played back using only codecs in Fedora (and even then, only with GStreamer) is WebM. And I don't think Minitube knows to prefer WebM to other formats (and actually if it did, it'd probably crash xine-lib, which is the default Phonon backend, so that's not that great an idea at this time).

Again, please only ask for Minitube to be in Fedora if you actually TESTED it on a system with NO packages from RPM Fusion installed (in particular, NONE of xine-lib-extras-freeworld, gstreamer-plugins-ugly, gstreamer-plugins-bad, gstreamer-plugins-bad-nonfree or gstreamer-ffmpeg). I do not expect it to work at all! (And it'd require manually switching to a non-default Phonon backend in any case.)

Comment 11 Kevin Kofler 2010-08-04 08:30:31 UTC
(The Phonon backend default is systemwide, we cannot make only Minitube default to GStreamer.)

Comment 12 Chen Lei 2010-08-04 08:45:28 UTC
(In reply to comment #10)
> If you have Gnash successfully playing videos, you have several codec packages
> from RPM Fusion.
> 

This fact is gnash is already in fedora repo for a very long time, I can't see a reason why this package should be rejected by fedora policy.

(In reply to comment #11)
> (The Phonon backend default is systemwide, we cannot make only Minitube default
> to GStreamer.)    

This is a packaging issue related to phonon package in fedora, it's irrelevant to this Review Request. Actually, I think phonon xine should be default only in KDE. Gstreamer backend works better in gnome/xfce/meego(Qt/mx UX) desktop, xine is not installed by default in those desktop.


So I suggest not to close this request before enough talk(maybe opinions from more people or decisions from FESCo). At least, this package itself is legal and don't need a decision from Fedora Legal.

Comment 13 Kevin Kofler 2010-08-04 09:09:01 UTC
> This fact is gnash is already in fedora repo for a very long time,

Gnash is functional without codec packages, it just cannot play any audio/video content, but vector animations (including still images) work. This package in its current state is of no use at all without non-Fedora codec packages.

> I can't see a reason why this package should be rejected by fedora policy.

https://fedoraproject.org/wiki/Packaging/Guidelines#Packages_which_are_not_useful_without_external_bits


> This is a packaging issue related to phonon package in fedora, it's irrelevant
> to this Review Request. Actually, I think phonon xine should be default only in
> KDE. Gstreamer backend works better in gnome/xfce/meego(Qt/mx UX) desktop, xine
> is not installed by default in those desktop.

The same reasons for choosing a given Phonon backend apply irrelevantly of the desktop in use. But this is not related to this review request indeed.

Comment 14 Chen Lei 2010-08-04 09:32:35 UTC
(In reply to comment #13)
> > This fact is gnash is already in fedora repo for a very long time,
> 
> Gnash is functional without codec packages, it just cannot play any audio/video
> content, but vector animations (including still images) work. This package in
> its current state is of no use at all without non-Fedora codec packages.
> 
Webm will be widely used in youtube in the foreseeable future, now youtube already have some webm tests. gstreamer-plugins-bad-free provides vp8 codec. So add a very short life package to rpmfusion is meaningless.

> 
> 
> > This is a packaging issue related to phonon package in fedora, it's irrelevant
> > to this Review Request. Actually, I think phonon xine should be default only in
> > KDE. Gstreamer backend works better in gnome/xfce/meego(Qt/mx UX) desktop, xine
> > is not installed by default in those desktop.
> 
> The same reasons for choosing a given Phonon backend apply irrelevantly of the
> desktop in use. But this is not related to this review request indeed.    

I think this package itself is irrelevant to any phonon backends actually and should not depends on phonon backends, it's probable minitube can also work with vlc backend.

rpm -qa|grep phonon
phonon-4.4.2-1.fc13.x86_64
phonon-backend-gstreamer-4.4.2-1.fc13.x86_64

I take a quick look at phonon spec, it seems phonon don't requires xine backend explicitly, phonon only depends on a virtual provides phonon-backend. The fact why xine backend is installed by default is its name have a higher priority over phonon-backend-gstreamer in yum, it seems if we package vlc backend, then the default backend will be switch to vlc if we don't add phonon-xine-backend to KDE default comps. Also, I can easily install gstreamer backend by default to meego in this way to avoid xine backend.

Comment 15 Chen Lei 2010-08-04 09:44:28 UTC
If this package doesn't depend on either xine-lib-freeworld or gstreamer-plugins-ugly, then adding this package to rpmfusion is strange because the package itself is free and also don't depend on any external bits that can't be included in fedora. Adding either xine-lib-freeworld or gstreamer-plugins-ugly to requires is inadequate though minitube can't play many videos in youtube, we can not force people to use one phonon backend regardless of the recommended gstreamer backend in minitube homepage.


Note You need to log in before you can comment on or make changes to this bug.