Bug 621611 - Wrong permission test when deciding whether to rebuild initrd (yuminstall.py)
Summary: Wrong permission test when deciding whether to rebuild initrd (yuminstall.py)
Status: CLOSED NEXTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: anaconda   
(Show other bugs)
Version: 5.5
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Anaconda Maintenance Team
QA Contact: Release Test Team
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-05 16:20 UTC by Charlie Brady
Modified: 2010-08-05 17:01 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-08-05 17:01:32 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description Charlie Brady 2010-08-05 16:20:32 UTC
System.map file does not have execute permission, so these tests will always evaluate false, and initrd will not be rebuilt.

...
    def copyExtraModules(self, anaconda, modulesList):
        kernelVersions = self.kernelVersionList()
        foundModule = 0
...
        if foundModule == 1:
            for (n, arch, tag) in kernelVersions:
                if os.access("/boot/System.map-%s" %(n,), os.X_OK):
                    recreateInitrd(n, anaconda.rootPath)

...
    def doPostInstall(self, anaconda):
        if flags.test:
            return
...
        if len(self._installedDriverModules) > 0 and len(self._installedDriverModules) == len(anaconda.id.extraModules):
            for (n, arch, tag) in self.kernelVersionList():
                if os.access("/boot/System.map-%s" %(n,), os.X_OK):
                    recreateInitrd(n, anaconda.rootPath)
...

I think you should have os.R_OK in these two places.

Comment 1 Chris Lumens 2010-08-05 17:01:32 UTC
Thanks for the bug report.  This is fixed in Fedora as well as the next major release of RHEL.  If you require this fix in an update release of RHEL5, please speak to your support representative who will raise it through the appropriate channels.

In the meantime, if you have a lot of installations to do, you can apply the fix yourself to yuminstall.py, create an updates image with that file in it, and use updates= in your further installs.


Note You need to log in before you can comment on or make changes to this bug.