Bug 621721 - Invalid revision in translations gets picked up late in package/build process
Summary: Invalid revision in translations gets picked up late in package/build process
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: 1.6
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jeff Fearn 🐞
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2010-08-05 22:47 UTC by Jeff Fearn 🐞
Modified: 2010-11-24 04:17 UTC (History)
4 users (show)

Clone Of:
Last Closed: 2010-10-08 20:42:23 UTC

Attachments (Terms of Use)

Description Jeff Fearn 🐞 2010-08-05 22:47:02 UTC
Description of problem:
For translations the package revision is set in the *_Type.po file via the Project-Id-Version entry. If this value is invalid it does not get detected until the binary package is being built.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Find a translated book
2. set Project-Id-Version to an invalid revision text
3. create SRPM

Actual results:
The invalid revision is not detected.

Expected results:
The invalid revision is detected.

Additional info:
It appears that the SRPM has an invalid NVR as well

Release:       %{?dist}

Comment 1 Jeff Fearn 🐞 2010-08-06 00:31:07 UTC
Fixed validation of revision in 'sub package'.

Will now output:

$ publican package --lang es-ES

DEBUG: Publican: config loaded
Running clean process to ensure stale content is not bundled in packages.
Clean: Removing tmp and publish directories.
Project-Id-Version 'Book_Info\n' in es-ES/Book_Info.po is not a valid release value. at /usr/bin/publican line 641

Fixed in Build 2.1-0%{?dist}.t20

Comment 2 Ruediger Landmann 2010-08-06 05:36:27 UTC
Publican 2.1.t26 catches invalid values of Project-Id-Version very shortly after you run publican package.

However, when "Project-Id-Version" is set to 0, validation also fails.

Comment 3 Jeff Fearn 🐞 2010-08-06 06:01:26 UTC
Good old zero, always forgotten.

Fixed zero in build: 2.1-0%{?dist}.t29

Comment 4 Ruediger Landmann 2010-08-07 13:11:19 UTC
Confirmed that "Project-Id-Version: 0" gets packaged correctly in build: 2.1-0%{?dist}.t29

Comment 5 Fedora Update System 2010-10-06 05:48:44 UTC
publican-2.2-0.fc13 has been submitted as an update for Fedora 13.

Comment 6 Fedora Update System 2010-10-06 05:50:03 UTC
publican-2.2-0.fc12 has been submitted as an update for Fedora 12.

Comment 7 Fedora Update System 2010-10-06 05:50:06 UTC
publican-2.2-0.fc14 has been submitted as an update for Fedora 14.

Comment 8 Fedora Update System 2010-10-08 20:40:10 UTC
publican-2.2-0.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.