Bug 622545 - Only part of message marked for translation
Summary: Only part of message marked for translation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Ales Kozumplik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-09 17:15 UTC by Göran Uddeborg
Modified: 2014-09-30 23:39 UTC (History)
3 users (show)

Fixed In Version: anaconda-14.17-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-15 07:10:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Göran Uddeborg 2010-08-09 17:15:37 UTC
Description of problem:
In loader/loader.c there is this code:

    const char *reason_no = "";
    const char *reason_method = " using this install method";
    const char *reason = reason_no;
…
    if (…) {
        …
        reason = reason_method;
    }
…    
    checked_asprintf(&buf, _("You do not have enough RAM to install %s "
                             "on this machine%s."), getProductName(), reason);

The string starting "You do" and ending in "%s." is properly marked for translation.  But the string being filled in for the %s, starting with "using" is not.  So the result, if that value for "reason" is used, will be a message starting with a translated message, but ending in the English.

It is not a good solution to only mark the "using" string for translation.  In general it is not a good to "build" sentences in this way, if they are to be translated.  This case would happen to work in my language (Swedish), but I'm sure it will not for other languages.

A better solution would be to let both reason_no and reason_method be the complete message, marked for translation, and then use only the variable in the printf.  (See for example http://library.gnome.org/devel/glib/stable/glib-I18N.html#N-:CAPS for details.)

Version-Release number of selected component (if applicable):
POT created 2010-08-05 16:19-0400 and made available through Transifex for translation.

Comment 1 Ales Kozumplik 2010-08-30 11:10:04 UTC
Thanks for the bug report. The fix e05aa736814a1a7a6b77cf48ec264a6b4b7f1bb9 has been committed to f14-branch.

Comment 2 Fedora Update System 2010-09-03 15:10:37 UTC
anaconda-14.17-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/anaconda-14.17-1.fc14

Comment 3 Fedora Update System 2010-09-03 16:42:59 UTC
anaconda-14.17-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update anaconda'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/anaconda-14.17-1.fc14

Comment 4 Fedora Update System 2010-09-15 07:09:47 UTC
anaconda-14.17-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.