Bug 622763

Cleaned up flags. The rhel6 testblocking bug fix will be a quirk in udev as it should be done there to ensure backward compatibility. This bug will be used to fix xen in order to support distros that don't have the quirk implemented.

Created attachment 480791 [details]
Implement new SCSI commands to ioemu/hw/ide.c

Hi,
this is the patch to fix the CD-ROM and DVD-ROM reading issue for drivers
that don't have quirks implemented.

The GET CONFIGURATION SCSI command implementation is based on the document
from T10 that could be found at [1]. READ_DVD_STRUCTURE and SET_SPEED bits
have been backported as well.

Testing: This patch has been tested on RHEL-5 x86_64 dom0 and the test
results in the guest are as follows:

Before the patch applied:
main: probing: '/dev/sr0'
cd_media_compat: CDROM_DRIVE_STATUS != CDS_DISC_OK
cd_inquiry: INQUIRY: [QEMU    ][QEMU CD-ROM     ][0.8.]
cd_profiles: GET CONFIGURATION: number of profiles 4
cd_profiles: current profile 0x00
cd_profiles: no current profile, assuming no media
ID_CDROM=1

After the patch has been applied:
main: probing: '/dev/sr0'
cd_inquiry: INQUIRY: [QEMU    ][QEMU CD-ROM     ][0.8.]
cd_profiles: GET CONFIGURATION: number of profiles 20
cd_profiles: current profile 0x08
cd_media_toc: READ TOC: len: 20
cd_media_toc: track=1 info=0x4(data) start_block=0
cd_media_toc: last track 1 starts at block 0
cd_media_info: disk type 00
ID_CDROM=1
ID_CDROM_MEDIA=1
ID_CDROM_MEDIA_CD=1
ID_CDROM_MEDIA_TRACK_COUNT_DATA=1

So based on this this is working fine. Also, installation of RHEL-6-Beta
HVM guest has been tried to try whether the guest can run into those
installation issues but it was not reproduced any longer.

Michal

[1] http://www.t10.org/ftp/t10/document.97/97-263r0.pdf

A regression bug 688456 is introduced by this fix.

Setting to modified as regression is handled by separate bz.

Result of Installation HVM guest from CDROM for all distro

Three version of HVM guests failed for install from DVD iso:
RHEl5.5-64
Win2008-64
WinVista-64

Host:
xen-3.0.3-127.el5
kernel-xen-2.6.18-254.el5
Intel 64bit

Guest:
Linux:
+-------------+-------------+-------------+-------------+-------------+
|   RHEL3.9   |   RHEL4.8   |   RHEL5.5   |   RHEL6.0   |    RHEL6.1  |
+------+------+------+------+------+------+------+------+------+------+
|  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |
+------+------+------+------+------+------+------+------+------+------+
| PASS | PASS | PASS | PASS | PASS | FAIL | PASS | PASS | PASS | PASS |
+------+------+------+------+------+------+------+------+------+------+

Windows:
+-------------+-------------+-------------+-------------+-------------+-------------+
| Windows XP  |   Win2003   |   Win2008   |  Win2008r2  |   WinVista  |     Win7    |
+------+------+------+------+------+------+------+------+------+------+------+------+  
|  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |
+------+------+------+------+------+------+------+------+------+------+------+------+  
| PASS | N/A  | PASS | PASS | PASS | FAIL | N/A  | PASS | PASS | FAIL | PASS | PASS |
+------+------+------+------+------+------+------+------+------+------+------+------+

Ignore the comment 15, update the info "RHEL5.5 -> RHEL5.6"

The test of installing HVM guests via iso images failed (RHEL5.6-64, Win2008-64, WinVista-64).

Intel host with :
xen-3.0.3-127.el5
kernel-xen-2.6.18-254.el5

Guest:
Linux:
+-------------+-------------+-------------+-------------+-------------+
|   RHEL3.9   |   RHEL4.8   |   RHEL5.6   |   RHEL6.0   |    RHEL6.1  |
+------+------+------+------+------+------+------+------+------+------+
|  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |
+------+------+------+------+------+------+------+------+------+------+
| PASS | PASS | PASS | PASS | PASS | FAIL | PASS | PASS | PASS | PASS |
+------+------+------+------+------+------+------+------+------+------+

Windows:
+-------------+-------------+-------------+-------------+-------------+-------------+
| Windows XP  |   Win2003   |   Win2008   |  Win2008r2  |   WinVista  |     Win7    |
+------+------+------+------+------+------+------+------+------+------+------+------+  
|  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |  32  |  64  |
+------+------+------+------+------+------+------+------+------+------+------+------+  
| PASS | N/A  | PASS | PASS | PASS | FAIL | N/A  | PASS | PASS | FAIL | PASS | PASS |
+------+------+------+------+------+------+------+------+------+------+------+------+

1. for RHEL5.6 x86_64 guest, we saw guest crash at random stages, for example:
[1]. after skip installation number, it reboot immediately and re-boot from cd
[2]. after disk format, it qemu-dm crash immediately:
$ ps aux | grep qemu-dm
root      9617  6.0  0.0      0     0 ?        Z    02:54   0:17 [qemu-dm] <defunct>
$ cat /var/log/xen/qemu-dm.9617.log 
domid: 99
qemu: the number of cpus is 1
Using file  in read-write mode
Using file  in read-only mode
Watching /local/domain/99/logdirty/next-active
Watching /local/domain/0/device-model/99/command
xs_read(): vncpasswd get error. /vm/7b8795f8-40a8-6d53-0d95-667c709a18ac/vncpasswd.
char device redirected to /dev/pts/3
qemu_map_cache_init nr_buckets = 10000
shared page at pfn 3ffff
buffered io page at pfn 3fffd
xs_read(/vm/7b8795f8-40a8-6d53-0d95-667c709a18ac/rtc/timeoffset): read error
I/O request not ready: 0, ptr: 0, port: 0, data: 0, count: 0, size: 0
Triggered log-dirty buffer switch
gpe_en_write: addr=0x1f6c, val=0x0.
gpe_sts_write: addr=0x1f68, val=0xff.
gpe_en_write: addr=0x1f6d, val=0x0.
gpe_sts_write: addr=0x1f69, val=0xff.
gpe_en_write: addr=0x1f6e, val=0x0.
gpe_sts_write: addr=0x1f6a, val=0xff.
gpe_en_write: addr=0x1f6f, val=0x0.
gpe_sts_write: addr=0x1f6b, val=0xff.
gpe_en_write: addr=0x1f6c, val=0x8.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
ACPI PCI hotplug: read addr=0x10c1, val=0x0.
ACPI PCI hotplug: read addr=0x10c2, val=0x0.
inp: bad size: 0 0

2. For Windows 2008 x86_64 and vista x86_64, we hit the same BSOD issue as original reported during installation.
Or you can reproduce it by booting up the Win2008-64bit guest with the qemu ide cd-rom attached, then open server-manager -> storage -> disk management (crash now)

As the problem for this and 688456 is the same, marking this as duplicate.

*** This bug has been marked as a duplicate of bug 688456 ***

Reopen this bz as it is reverted from 5.7 due to regressions. Patch is moved to 5.8 till regressions are solved.

This issue was hit in RHEL6.0 development and were fixed in udev. As we try to add missing implementation, couple of regression was introduced. This issue was not hit anywhere else so we will not add this feature to RHEL5 due to  too high risk level in current state of RHEL5 lifetime.