Bug 623561 - prefdm.service should wait for livesys.service
prefdm.service should wait for livesys.service
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: systemd (Show other bugs)
14
All Linux
low Severity medium
: ---
: ---
Assigned To: Lennart Poettering
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-12 02:51 EDT by Adam Williamson
Modified: 2010-08-18 21:09 EDT (History)
4 users (show)

See Also:
Fixed In Version: systemd-7-3.fc14
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-08-18 21:09:27 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
patch to add the dependency to prefdm.service (415 bytes, patch)
2010-08-12 02:51 EDT, Adam Williamson
no flags Details | Diff
updated version of the patch (420 bytes, patch)
2010-08-12 04:15 EDT, Adam Williamson
no flags Details | Diff

  None (edit)
Description Adam Williamson 2010-08-12 02:51:40 EDT
Created attachment 438357 [details]
patch to add the dependency to prefdm.service

When booting a Fedora live service, a livesys service can potentially make some changes to X configuration (it has special case X configs for some OLPC devices, and it should configure X to use a specific driver if you pass the parameter xdriver=foo - this doesn't currently work, but I'm submitting a patch for that to spin-kickstarts). However, in systemd, prefdm.service isn't configured to wait for livesys.service, so these X config changes aren't actually respected (at least in my test systems) because systemd manages to start X before livesys service gets to making the changes.

prefdm.service should be patched to have After = livesys.service . Patch attached.

(Testing this is a bit tricky because you need a non-Intel, non-Nvidia system to be sure, and it seems like kvm vms currently hang if you try to use the vesa driver. So for now, my 'test' for this is to boot a live image with the fixes to systemd and spin-kickstarts, and pass parameters 'xdriver=vesa nomodeset'. If the live image gets to a graphical desktop using the cirrus driver it's broken, and if the live image completely freezes on X start, it's working!)
Comment 1 Adam Williamson 2010-08-12 02:51:53 EDT

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
Comment 2 Adam Williamson 2010-08-12 04:14:28 EDT
correction: it should wait for livesys-late.service , not just livesys.service . updated patch attached. this does 'the right thing' in my hang test...



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
Comment 3 Adam Williamson 2010-08-12 04:15:24 EDT
Created attachment 438364 [details]
updated version of the patch
Comment 4 Fedora Update System 2010-08-12 11:29:51 EDT
systemd-7-3.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/systemd-7-3.fc14
Comment 5 Bill Nottingham 2010-08-12 12:26:53 EDT
Given when prefdm historically starts, shouldn't it just be after local.service instead?
Comment 6 Adam Williamson 2010-08-12 12:40:29 EDT
bill: I think it's more correct to think of the relationships as being 'dependencies', since systemd is intended not to be sequential at all. we can't necessarily assume that local.service is being started after livesys-late.service unless they have that relationship expressed between them...



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
Comment 7 Bill Nottingham 2010-08-12 12:50:59 EDT
We sort of can, due to the fact that it sets SysVStartPriority. Of course, it's possibly better defined as a target, since it by definition needs to be After: everything-else.
Comment 8 Fedora Update System 2010-08-12 15:48:18 EDT
systemd-7-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update systemd'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/systemd-7-3.fc14
Comment 9 Lennart Poettering 2010-08-14 14:02:56 EDT
I generally believe that we should keep the amount of synchronization and dependencies at a minimum. That means that I'd rather not add an ordering dep between local.service in prefdm.service
Comment 10 Fedora Update System 2010-08-18 21:09:18 EDT
systemd-7-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.