Bug 623686 - Review Request: ccgo - An IGS client written in C++
Summary: Review Request: ccgo - An IGS client written in C++
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL: http://ccdw.org/~cjj/prog/ccgo/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-12 14:19 UTC by Petr Pisar
Modified: 2010-08-16 08:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-08-16 08:48:30 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2010-08-12 14:19:18 UTC
Spec URL: http://ppisar.fedorapeople.org/ccgo/ccgo.spec
SRPM URL: http://ppisar.fedorapeople.org/ccgo/ccgo-0.3.6.4-1.fc13.src.rpm
Description:
ccGo is a program allows you to play go with GNU Go on your computer or with
other players on an IGS on the Internet. It support smart game format (SGF)
suitable for exchanging game records.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2397292

I added gnugo to Requires because ccgo prints warning only to stderr if one is missing. Despite that ccgo can be used without it if someone wants to play against people over Internet or view recorded games locally.

$ rpmlint ccgo.spec ../SRPMS/ccgo-0.3.6.4-1.fc13.src.rpm ../RPMS/x86_64/ccgo-*
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -pqlv ../RPMS/x86_64/ccgo-0.3.6.4-1.fc13.x86_64.rpm 
-rwxr-xr-x    1 root    root                  1305768 srp 12 16:09 /usr/bin/ccgo
-rw-r--r--    1 root    root                      198 srp 12 16:09 /usr/share/applications/ccgo.desktop
drwxr-xr-x    2 root    root                        0 srp 12 16:09 /usr/share/doc/ccgo-0.3.6.4
-rw-r--r--    1 root    root                       41 kvě 10  2009 /usr/share/doc/ccgo-0.3.6.4/AUTHORS
-rw-r--r--    1 root    root                    35068 kvě 10  2009 /usr/share/doc/ccgo-0.3.6.4/COPYING
-rw-r--r--    1 root    root                      554 kvě 10  2009 /usr/share/doc/ccgo-0.3.6.4/README
-rw-r--r--    1 root    root                     9910 srp 12 16:09 /usr/share/locale/hu_HU/LC_MESSAGES/ccgo.mo
-rw-r--r--    1 root    root                    12040 srp 12 16:09 /usr/share/locale/zh_CN/LC_MESSAGES/ccgo.mo
-rw-r--r--    1 root    root                    12041 srp 12 16:09 /usr/share/locale/zh_TW/LC_MESSAGES/ccgo.mo
-rw-r--r--    1 root    root                      697 srp 12 16:09 /usr/share/man/man6/ccgo.6.gz
drwxr-xr-x    2 root    root                        0 srp 12 16:09 /usr/share/pixmaps/ccgo
-rw-r--r--    1 root    root                     4036 srp 12 16:09 /usr/share/pixmaps/ccgo.xpm
-rw-r--r--    1 root    root                     2241 srp 12 16:09 /usr/share/pixmaps/ccgo/banner.png
-rw-r--r--    1 root    root                    20569 srp 12 16:09 /usr/share/pixmaps/ccgo/black_stone.png
-rw-r--r--    1 root    root                    12974 srp 12 16:09 /usr/share/pixmaps/ccgo/board.png
-rw-r--r--    1 root    root                    15844 srp 12 16:09 /usr/share/pixmaps/ccgo/ccgo.png
-rw-r--r--    1 root    root                    14314 srp 12 16:09 /usr/share/pixmaps/ccgo/gamelist_icon.png
-rw-r--r--    1 root    root                    15265 srp 12 16:09 /usr/share/pixmaps/ccgo/igs_icon.png
-rw-r--r--    1 root    root                    14714 srp 12 16:09 /usr/share/pixmaps/ccgo/main_icon.png
-rw-r--r--    1 root    root                    15250 srp 12 16:09 /usr/share/pixmaps/ccgo/matching_icon.png
-rw-r--r--    1 root    root                    15168 srp 12 16:09 /usr/share/pixmaps/ccgo/matchlist_icon.png
-rw-r--r--    1 root    root                    16542 srp 12 16:09 /usr/share/pixmaps/ccgo/observing_icon.png
-rw-r--r--    1 root    root                    14569 srp 12 16:09 /usr/share/pixmaps/ccgo/playerlist_icon.png
-rw-r--r--    1 root    root                    16075 srp 12 16:09 /usr/share/pixmaps/ccgo/playing_icon.png
-rw-r--r--    1 root    root                    15199 srp 12 16:09 /usr/share/pixmaps/ccgo/teaching_icon.png
-rw-r--r--    1 root    root                    15766 srp 12 16:09 /usr/share/pixmaps/ccgo/white_stone.png

Comment 1 Marcela Mašláňová 2010-08-13 09:05:53 UTC
I tested also install and learned go. Great package.

Comment 2 Petr Pisar 2010-08-13 09:14:15 UTC
New Package SCM Request
=======================
Package Name: ccgo
Short Description: An IGS client written in C++
Owners: ppisar
Branches: f12 f13 f14
InitialCC:

Comment 3 Jason Tibbitts 2010-08-14 14:50:48 UTC
I have to say that I find it odd that you feel it important to mention in the
summary the language the package is written in but don't explain what IGS
means.  I'd figure the implementation language is irrelevant to the function of
the package.

Git done (by process-git-requests).

Comment 4 Petr Pisar 2010-08-16 08:26:54 UTC
Yes, the description is not well balanced for non-Go players. I used official characteristic from sources and web page. ccgo is the only known free as speech native IGS client. There exist official closed source one, then one heavy java application and an old crashing Tcl/Tk implementation. That's all.

If you think it's serious problem let's change description to "An IGS (Internet Go Server) client written in C++".

Comment 5 Petr Pisar 2010-08-16 08:48:30 UTC
Thanks for review and GIT. Package has been built.


Note You need to log in before you can comment on or make changes to this bug.