Bug 624464 - Review Request: perl-Memoize-ExpireLRU - Expiry plug-in for Memoize that adds LRU cache expiration
Summary: Review Request: perl-Memoize-ExpireLRU - Expiry plug-in for Memoize that adds...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Memoize-E...
Depends On:
Blocks: 624471
TreeView+ depends on / blocked
Reported: 2010-08-16 14:45 UTC by Iain Arnell
Modified: 2010-09-01 05:57 UTC (History)
3 users (show)

Clone Of:
Last Closed: 2010-08-30 18:30:05 UTC
emmanuel: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Iain Arnell 2010-08-16 14:45:21 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Memoize-ExpireLRU.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Memoize-ExpireLRU-0.55-1.fc15.src.rpm

This module implements an expiry policy for Memoize that follows LRU
semantics, that is, the last n results, where n is specified as the
argument to the CACHESIZE parameter, will be cached.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2403928


Comment 1 Emmanuel Seyman 2010-08-16 21:21:38 UTC

Comment 2 Emmanuel Seyman 2010-08-16 21:40:07 UTC
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2404915

 [x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
1715a2a482c06ea698ff86d480b62d99  Memoize-ExpireLRU-0.55.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] Package does not own files or directories owned by other packages.

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: rawhide.x86_64
 [x] Package should compile and build into binary rpms on all supported
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2404915
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass


Comment 3 Iain Arnell 2010-08-17 03:05:44 UTC
Thanks for the review - but could you set the fedora-review flag, not fedora-cvs.

Comment 4 Iain Arnell 2010-08-18 03:06:47 UTC
New Package CVS Request
Package Name: perl-Memoize-ExpireLRU
Short Description: Expiry plug-in for Memoize that adds LRU cache expiration
Owners: iarnell
Branches: F-13 F-14
InitialCC: perl-sig

Comment 5 Kevin Fenzi 2010-08-18 21:20:14 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2010-08-19 03:16:57 UTC
perl-Memoize-ExpireLRU-0.55-1.fc14 has been submitted as an update for Fedora 14.

Comment 7 Fedora Update System 2010-08-19 03:17:02 UTC
perl-Memoize-ExpireLRU-0.55-1.fc13 has been submitted as an update for Fedora 13.

Comment 8 Fedora Update System 2010-08-20 01:48:24 UTC
perl-Memoize-ExpireLRU-0.55-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Memoize-ExpireLRU'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Memoize-ExpireLRU-0.55-1.fc13

Comment 9 Fedora Update System 2010-08-30 18:30:00 UTC
perl-Memoize-ExpireLRU-0.55-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2010-09-01 05:57:15 UTC
perl-Memoize-ExpireLRU-0.55-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.