Description of problem: BZ 3.6 seems to be more regex-greedy when turning some patterns to links. While previously link name only contained pattern, now it can contain surrounding white space or bracket, possibly other characters. Examples I've seen: - foo CVE-2000-0000 bar - foo [CVE-2000-0000] bar - foo() CVE-2000-0000 bar - foo: CVE-2000-0000 bar - foo: CVE-2000-0000 bar Previously, the link was always as: <a href="...">CVE-2000-0000</a>. Not sure if this is specific to CVE regex or may affect other references, so few experiments follow: - foo bug #123 bar - foo: bug #123 bar - foo() bug #123 bar - foo issue #123 bar - foo: issue #123 bar - foo() issue #123 bar - foo RHBA-2000:0000 bar - foo: RHBA-2000:0000 bar - foo() RHBA-2000:0000 bar
(In reply to comment #0) > Not sure if this is specific to CVE regex or may affect other references, so > few experiments follow: All of these look ok.
Another test pattern: http://link.to/somewhere?foo=bar CVE-2000-0000
Has anyone got time to look at this? Issue in comment #2 makes at least one bug I've just came across hardly readable.
(In reply to comment #3) > Has anyone got time to look at this? Issue in comment #2 makes at least one > bug I've just came across hardly readable. Sort of. I am pushing out an update today that disables the Red Hat code that does the linkification of these word patterns. Then we can do some more research to find out why it is breaking and then push the proper fix live in the near future. I would rather have the comments be readable for now that to have a convenience feature that is broken. Dave
*** Bug 627369 has been marked as a duplicate of this bug. ***
Can this bug be closed? Seems all the links in the above comments look fine to me? -- simon
My understanding is we dropped linkification of CVE ids as they were causing troubles, and never restored it. I'm not sure if we ever did turn RH[BES]A ids to links, so I'm unsure if that falls under regression or RFE classification, and it's also not completely clear what should be linked.
I don't think we can close this; the bug is about broken CVE links and from what I can see, they are all broken as of now. Unless we never intend to bring CVE-hotlinks back?
I can see the code where dkl commented out CVE linking in comments. Will have to have a look at the reason why this was done before re-enabling it.
This is ready for testing at https://bug624597.bugzilla.devel.redhat.com/ This also covers CAN-nnnn-nnnn links as dkl's original code did. -- simon
(In reply to comment #12) > This is ready for testing at https://bug624597.bugzilla.devel.redhat.com/ > This also covers CAN-nnnn-nnnn links as dkl's original code did. Should mention that for a link to be created it must be preceded by a space, a comma, a full stop or be the beginning of the comment AND it must be followed by a space, a comma, a full stop or be the end of the comment. -- simon
*** Bug 156316 has been marked as a duplicate of this bug. ***
This change is due to go live at 9pm UTC today (Monday July 9th) -- simon
The release date has been changed to 9pm UTC this Thursday (July 12th). Sorry for any inconvenience this late change may cause. -- simon
This change is now live.