Bug 626512 - gnome-power-manager legacy backlight handling code steps backlight by +/-1
gnome-power-manager legacy backlight handling code steps backlight by +/-1
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: gnome-power-manager (Show other bugs)
14
All Linux
low Severity medium
: ---
: ---
Assigned To: Richard Hughes
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-23 13:36 EDT by Will Woods
Modified: 2010-08-31 08:36 EDT (History)
2 users (show)

See Also:
Fixed In Version: gnome-power-manager-2.31.90-3.fc14
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-08-23 21:55:25 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
gnome-power-manager-2.31.90-fix-step-for-legacy-backlight.patch (2.30 KB, patch)
2010-08-23 13:36 EDT, Will Woods
no flags Details | Diff

  None (edit)
Description Will Woods 2010-08-23 13:36:08 EDT
Created attachment 440437 [details]
gnome-power-manager-2.31.90-fix-step-for-legacy-backlight.patch

The "legacy fallback" backlight handling code in gnome-power-manager increments/decrements the backlight value by one whenever the brightness buttons are pressed.

On systems like the Apple MacBook, where the backlight has upwards of 1024 brightness levels, this doesn't work.

The attached patch uses the gpm_brightness_get_step function (like the xrandr-based code does) to properly step the backlight value.
Comment 1 Fedora Update System 2010-08-23 15:20:50 EDT
gnome-power-manager-2.31.90-3.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/gnome-power-manager-2.31.90-3.fc14
Comment 2 Fedora Update System 2010-08-23 21:55:13 EDT
gnome-power-manager-2.31.90-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 3 Richard Hughes 2010-08-31 08:36:08 EDT
Applied upstream:

commit abd02c6724bb78823fd0ebee1956eaf11030ff8d
Author: Will Woods <wwoods@redhat.com>
Date:   Tue Aug 31 13:36:03 2010 +0100

    Use the correct backlight step value when using the legacy fallback device
    
    The 'legacy fallback' backlight handling code in gnome-power-manager
    increments/decrements the backlight value by one whenever the brightness
    buttons are pressed.
    
    On systems like the Apple MacBook, where the backlight has upwards of 1024
    brightness levels, this doesn't work.
    
    The attached patch uses the gpm_brightness_get_step function (like the
    xrandr-based code does) to properly step the backlight value.
    
    Signed-off-by: Richard Hughes <richard@hughsie.com>

Thanks.

Note You need to log in before you can comment on or make changes to this bug.