Bug 626512 - gnome-power-manager legacy backlight handling code steps backlight by +/-1
Summary: gnome-power-manager legacy backlight handling code steps backlight by +/-1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-power-manager
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-23 17:36 UTC by Will Woods
Modified: 2010-08-31 12:36 UTC (History)
2 users (show)

Fixed In Version: gnome-power-manager-2.31.90-3.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-08-24 01:55:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
gnome-power-manager-2.31.90-fix-step-for-legacy-backlight.patch (2.30 KB, patch)
2010-08-23 17:36 UTC, Will Woods
no flags Details | Diff

Description Will Woods 2010-08-23 17:36:08 UTC
Created attachment 440437 [details]
gnome-power-manager-2.31.90-fix-step-for-legacy-backlight.patch

The "legacy fallback" backlight handling code in gnome-power-manager increments/decrements the backlight value by one whenever the brightness buttons are pressed.

On systems like the Apple MacBook, where the backlight has upwards of 1024 brightness levels, this doesn't work.

The attached patch uses the gpm_brightness_get_step function (like the xrandr-based code does) to properly step the backlight value.

Comment 1 Fedora Update System 2010-08-23 19:20:50 UTC
gnome-power-manager-2.31.90-3.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/gnome-power-manager-2.31.90-3.fc14

Comment 2 Fedora Update System 2010-08-24 01:55:13 UTC
gnome-power-manager-2.31.90-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 3 Richard Hughes 2010-08-31 12:36:08 UTC
Applied upstream:

commit abd02c6724bb78823fd0ebee1956eaf11030ff8d
Author: Will Woods <wwoods>
Date:   Tue Aug 31 13:36:03 2010 +0100

    Use the correct backlight step value when using the legacy fallback device
    
    The 'legacy fallback' backlight handling code in gnome-power-manager
    increments/decrements the backlight value by one whenever the brightness
    buttons are pressed.
    
    On systems like the Apple MacBook, where the backlight has upwards of 1024
    brightness levels, this doesn't work.
    
    The attached patch uses the gpm_brightness_get_step function (like the
    xrandr-based code does) to properly step the backlight value.
    
    Signed-off-by: Richard Hughes <richard>

Thanks.


Note You need to log in before you can comment on or make changes to this bug.