Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 626566

Summary: IPR driver needs fixes to support the new Cubic-R adapter
Product: Red Hat Enterprise Linux 5 Reporter: IBM Bug Proxy <bugproxy>
Component: kernelAssignee: Steve Best <sbest>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: high Docs Contact:
Priority: high    
Version: 5.6CC: cward, jjarvis, nobody+PNT0273897, peterm, sglass, snagar
Target Milestone: betaKeywords: FutureFeature, OtherQA
Target Release: 5.6   
Hardware: ppc64   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 21:12:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 563573, 563589, 634213    
Bug Blocks: 531800, 557597    
Attachments:
Description Flags
Patch 1 of 16 - compilation warning fix
none
Patch 2 of 16 - 438b03311108b05a7b794bcf3941700853c62d1e backport
none
Patch 3 of 16 - 96d21f00ab59c9f27fad191d12a2ccfeff3c9108 backport
none
Patch 4 of 16 - 7be96900a2a662c67403559acd250f011b1d70db backport
none
Patch 5 of 16 - b8803b1cef28af785c4e903b9b1449898d68c758 backport
none
Patch 6 of 16 - 64ffdb762241c0a9c0c8fac7ea92aa0ba1529334 backport
none
Patch 7 of 16 - 409b0081ebb4e86c38d64a5abcf90b6374bd5b08 backport
none
Patch 8 of 16 - 74d8dda906fdce9c839b1fc126837eb232f3ea03 backport
none
Patch 9 of 16 - cd373dc8a9087e581bb6870e5609d2912b98aa38 backport
none
Patch 10 of 16 - 0880fbb544efaa05a0076d6fcc88c27b66547490 backport
none
Patch 11 of 16 - f82f5b6130bd016dd79858e0d30b859705d533d9 backport
none
Patch 12 of 16 - 2eb1c45ba73eada92fc7029d5a814c048ad6c629 backport
none
Patch 13 of 16 - b5a56b729339755572ee3ce961806423e8bb543d backport
none
Patch 14 of 16 - 31eee51794eedf3cba1fc299ac3980c32495548a backport
none
Patch 15 of 16 - d04ab9e5a5c633479033e0ebc8227350c0270931 backport
none
Patch 16 of 16 - patch to bump the driver version number none

Description IBM Bug Proxy 2010-08-23 20:32:14 UTC
---Problem Description---
The ipr driver requires additional patches to fix problems found with the bring up of the new adapters.
  
---uname output---
Linux devhv8-diamond-lp1.austin.ibm.com 2.6.32 #1 SMP Tue Jun 29 11:29:00 EDT 2010 ppc64 ppc64 ppc64
GNU/Linux
 
Machine Type = Power 6/7 
  
There are 16 new patches.  The list is below along with the upstream link if applicable.  The
attached patches will apply to the 2.6.18-208.el5 kernel source.


1.  This patch is a fix for a compilation warning for patch #4 submitted in RHBZ bug 563589 

2. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=438b03311108b05a7b794bcf3941700853c62d1e

3. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=96d21f00ab59c9f27fad191d12a2ccfeff3c9108

4. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=7be96900a2a662c67403559acd250f011b1d70db

5. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=b8803b1cef28af785c4e903b9b1449898d68c758

6. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=64ffdb762241c0a9c0c8fac7ea92aa0ba1529334

7. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=409b0081ebb4e86c38d64a5abcf90b6374bd5b08

8. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=74d8dda906fdce9c839b1fc126837eb232f3ea03

9. 
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=cd373dc8a9087e581bb6870e5609d2912b98aa38

10.
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=0880fbb544efaa05a0076d6fcc88c27b66547490

11.
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=f82f5b6130bd016dd79858e0d30b859705d533d9

12.
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=2eb1c45ba73eada92fc7029d5a814c048ad6c629

13.
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=b5a56b729339755572ee3ce961806423e8bb543d

14.
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=31eee51794eedf3cba1fc299ac3980c32495548a

15.
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=d04ab9e5a5c633479033e0ebc8227350c0270931

16. This patch is a simple bump to the driver version number.

This is a follow on to RHBZ bug 563589  and it needs to be picked up for the new adapter support in
the ipr
driver.

> *Server architecture(s) (please list all effected) (x86/POWER6/Z/etc.):
all

> *Server type (9117-MMA/HS20/s390/etc.):
all

> *General component (desktop/kernel/base OS/dev tools/etc.):
kernel

> *Other components involved (ixgbe/java/emulex/etc.):
none

> *Does the server have the latest GA firmware?
N/A

> *Has the problem been shown to occur on more than one system?
yes

> *Is a tested patch available?
yes - attached to this bug

> *If yes to the above, has it been approved upstream?
yes

> *What is the latest official Red Hat build on which this bug has been
>  seen?
kernel build 2.6.18-208.el5


This is not a feature request.  The feature request is bug 60204 which has the original patches to
support the feature.

There are now these additional patches required to support the feature.

Comment 1 IBM Bug Proxy 2010-08-23 20:32:19 UTC
Created attachment 440477 [details]
Patch 1 of 16 - compilation warning fix

Comment 2 IBM Bug Proxy 2010-08-23 20:32:23 UTC
Created attachment 440478 [details]
Patch 2 of 16 - 438b03311108b05a7b794bcf3941700853c62d1e backport

Comment 3 IBM Bug Proxy 2010-08-23 20:32:29 UTC
Created attachment 440479 [details]
Patch 3 of 16 - 96d21f00ab59c9f27fad191d12a2ccfeff3c9108 backport

Comment 4 IBM Bug Proxy 2010-08-23 20:32:32 UTC
Created attachment 440480 [details]
Patch 4 of 16 - 7be96900a2a662c67403559acd250f011b1d70db backport

Comment 5 IBM Bug Proxy 2010-08-23 20:32:36 UTC
Created attachment 440481 [details]
Patch 5 of 16 - b8803b1cef28af785c4e903b9b1449898d68c758 backport

Comment 6 IBM Bug Proxy 2010-08-23 20:32:41 UTC
Created attachment 440482 [details]
Patch 6 of 16 - 64ffdb762241c0a9c0c8fac7ea92aa0ba1529334 backport

Comment 7 IBM Bug Proxy 2010-08-23 20:32:45 UTC
Created attachment 440483 [details]
Patch 7 of 16 - 409b0081ebb4e86c38d64a5abcf90b6374bd5b08 backport

Comment 8 IBM Bug Proxy 2010-08-23 20:32:50 UTC
Created attachment 440484 [details]
Patch 8 of 16 - 74d8dda906fdce9c839b1fc126837eb232f3ea03 backport

Comment 9 IBM Bug Proxy 2010-08-23 20:32:57 UTC
Created attachment 440485 [details]
Patch 9 of 16 - cd373dc8a9087e581bb6870e5609d2912b98aa38 backport

Comment 10 IBM Bug Proxy 2010-08-23 20:33:02 UTC
Created attachment 440486 [details]
Patch 10 of 16 - 0880fbb544efaa05a0076d6fcc88c27b66547490 backport

Comment 11 IBM Bug Proxy 2010-08-23 20:33:10 UTC
Created attachment 440487 [details]
Patch 11 of 16 - f82f5b6130bd016dd79858e0d30b859705d533d9 backport

Comment 12 IBM Bug Proxy 2010-08-23 20:33:16 UTC
Created attachment 440488 [details]
Patch 12 of 16 - 2eb1c45ba73eada92fc7029d5a814c048ad6c629 backport

Comment 13 IBM Bug Proxy 2010-08-23 20:33:22 UTC
Created attachment 440489 [details]
Patch 13 of 16 - b5a56b729339755572ee3ce961806423e8bb543d backport

Comment 14 IBM Bug Proxy 2010-08-23 20:33:28 UTC
Created attachment 440490 [details]
Patch 14 of 16 - 31eee51794eedf3cba1fc299ac3980c32495548a backport

Comment 15 IBM Bug Proxy 2010-08-23 20:33:33 UTC
Created attachment 440491 [details]
Patch 15 of 16 - d04ab9e5a5c633479033e0ebc8227350c0270931 backport

Comment 16 IBM Bug Proxy 2010-08-23 20:33:39 UTC
Created attachment 440492 [details]
Patch 16 of 16 - patch to bump the driver version number

Comment 17 IBM Bug Proxy 2010-08-23 21:52:20 UTC
------- Comment From sglass.com 2010-08-23 17:46 EDT-------
Hi John,
This is the bug we discussed on Friday.  This new featue was added to RHEL 5.6 with RH bug 563573.  Unfortunately, the hadware was not complete when the initial driver was put upstream.  Additional changes had to be made as the hardware/firmware completed development.

If these changes are not picked up, then the driver which is due out in April 2011 will not be supported.  It would need to wait until RHEL 5.7 and when ever that GA'ed.

Please consider picking it up.

Thanks,

Stephanie

Comment 18 John Jarvis 2010-08-23 23:07:11 UTC
IBM is signed up to test and provide feedback.

Comment 19 John Jarvis 2010-08-25 14:19:09 UTC
This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

Comment 20 IBM Bug Proxy 2010-08-27 21:33:07 UTC
------- Comment From wayneb.com 2010-08-27 17:25 EDT-------
Patches 7 - 15 had the wrong ID links.  Here are the correct links:

7.  ipr: fix resource path display and formatting

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=5adcbeb34d2a031d3baca227eef23e56734006ba

8.  ipr: add endian swap enablement for 64 bit adapters

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=8701f18504751a5b89be3203e28c5ec04c147167

9.  ipr: add writeq definition if needed

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=c5f10187965f93ef7ef67da9c7c449b13b6dee1b

10.  ipr: move setting of the allow_restart flag for vsets and disks

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=56115598c571cadd4b465836e1423a452a908c89

11.  ipr: add MMIO write to perform BIST for 64 bit adapters

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=cb237ef7a45f22373575b2d2ad2d06f7d38d6bce

12.  ipr: add support for new Obsidian-E embedded adapter

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=b0f56d3d6becfb338a41615d6ce43d41547502c3

13.  ipr: change endian swap key to match hardware spec change

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=4289a08680d646dcc18e291cb437a292738e504f

14.  ipr: fix transition to operational for new adapters

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=1df79ca4223632113f14618833b8bb1727a8ca15

15.  ipr: fix resource type update and add sdev and shost attributes

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=75576bb9b208d7c66822f310cdef9ca2d72c879c

Comment 21 Steve Best 2010-08-30 15:22:26 UTC
posted to rh kernel mailing list
http://post-office.corp.redhat.com/archives/rhkernel-list/2010-August/msg01797.html

Comment 38 Jarod Wilson 2010-09-10 21:41:08 UTC
in kernel-2.6.18-219.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 40 Chris Ward 2010-11-09 13:40:25 UTC
~~ Attention Customers and Partners - RHEL 5.6 Public Beta is now available on RHN ~~

A fix for this 'OtherQA' BZ should be present and testable in the release. 

If this Bugzilla is verified as resolved, please update the Verified field above with an appropriate value and include a summary of the testing executed and the results obtained.

If you encounter any issues or have questions while testing, please describe them and set this bug into NEED_INFO. 

If you encounter new defects or have additional patches to request for inclusion, promptly escalate the new issues through your support representative.

Finally, future Beta kernels can be found here:
 http://people.redhat.com/jwilson/el5/

Note: Bugs with the 'OtherQA' keyword require Third-Party testing to confirm the request has been properly addressed. See: https://bugzilla.redhat.com/describekeywords.cgi#OtherQA ).

Comment 41 John Jarvis 2010-11-18 21:03:46 UTC
This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

Comment 42 Chris Ward 2010-12-02 15:31:48 UTC
Reminder! There should be a fix present for this BZ in snapshot 3 -- unless otherwise noted in a previous comment.

Please test and update this BZ with test results as soon as possible.

Comment 43 IBM Bug Proxy 2010-12-02 18:52:44 UTC
------- Comment From klebers.ibm.com 2010-12-02 13:49 EDT-------
Fixes available on RHEL5.6 Snaptshot3 (20101124.1) kernel 2.6.18-233.el5. Closing bug.

Thank you,
Kleber

Comment 45 errata-xmlrpc 2011-01-13 21:12:47 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html