Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 627679

Summary:	jobserver: Historical Jobs need to fall back on its entry summary data if needed
Product:	Red Hat Enterprise MRG	Reporter:	Pete MacKinnon <pmackinn>
Component:	condor	Assignee:	Pete MacKinnon <pmackinn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	MRG Quality Engineering <mrgqe-bugs>
Severity:	medium	Docs Contact:
Priority:	high
Version:	beta	CC:	matt
Target Milestone:	1.3
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-09-27 17:11:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	623238

Description Pete MacKinnon 2010-08-26 16:26:21 UTC

If a history file has been archived the JobServer currently doesn't update it's job entries to follow the archived file. The lookup for a Historical Job's ad will occur in the current history file which will not be correct for that job's ftell seek pointers. Thus the lookup will fail:

08/26/10 09:51:22 HistoricalJob::GetAd - empty ad

We need a fail-safe in the HistoricalJob GetAd impl to populate the ad minimally with its summary info from its HistoryEntry data, regardless if we can't retrieve the original complete job ad for any reason.

Comment 1 Pete MacKinnon 2010-08-30 14:02:47 UTC

Justin, I've made a fix for this but wanted to get your input on how you wanted to receive summary data from these kinds of jobs. Right now you could get some empty strings for HoldReason, RemoveReason, etc.

Would you prefer not to get any "empty" attributes at all or would you like to have a minimal consistent set of attributes reported, empty or not?

Comment 2 Pete MacKinnon 2010-09-02 01:30:35 UTC

Modified in FH sha 634e1cd

Historical Jobs now provide their summary directly from their in-memory entry data without relying on trying to find the full ad in a history file. Errors are reported to the QMF caller if for some reason the requested ad couldn't be reconstructed from the history file.

Made the decision to return attributes with non-empty strings due to quoting headaches.